Since glibc-2.26, cmake skipped over nfs when standalone tirpc
was installed in tirpc subdir (as done by Debian, Fedora, Arch, Gentoo...)
Use FindTIRPC and make kio_nfs optional that way
FindTIRPC taken from https://phabricator.kde.org/D12761
dfaure | |
rdieter | |
sitter |
Dolphin |
Since glibc-2.26, cmake skipped over nfs when standalone tirpc
was installed in tirpc subdir (as done by Debian, Fedora, Arch, Gentoo...)
Use FindTIRPC and make kio_nfs optional that way
FindTIRPC taken from https://phabricator.kde.org/D12761
Built with libtirpc successfully.
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
LGTM
I do wonder if we should support ntirpc too though. At a glance it's largely the same finder s/tirpc/ntirpc/. Admittedly I do not know why there are two libs and both seem to actively get commits.
nfs/CMakeLists.txt | ||
---|---|---|
2 | I think we need CheckCXXSymbolExists here. Since we use and link from C++, whether or not the symbols can be found and linked from C is of no importance. | |
15โ26 | As you are in the code already, maybe replace this abomination with a configure_file? ๐ |
Fine by me to land as-is, it can't be worse than what the current state of afairs in master is... which is to say in master nothing is working for me :'<