add a "level" api that has the same meaning as in the Kirigami Heading component,
This makes easier for QWidget apps to follow the typographi HIG at
D16864 QWidget and QML apps will look more similar and config dialogs
the same.
together other diffs introduces more consistency within SystemSettings
between QWidget and QML based kcms
Details
Details
- Reviewers
ngraham - Group Reviewers
Plasma VDG - Commits
- R236:d3964629cbff: Add level api from Kirigami.Heading
ran a lot of config dialogs
Diff Detail
Diff Detail
- Repository
- R236 KWidgetsAddons
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
with a QWidget KCM
In those screenshots, "< Fonts" is basically just a named back button. Should it really have the same size and visual weight as the active KCMs' title?
Comment Actions
I think so, it's the title of what the underlying listview is about, which is "the other kcm you can open now" which should have the same weight as what the current kcm is
that's for D17192 btw
| src/ktitlewidget.cpp | ||
|---|---|---|
| 132 | Setting 0 margins effectively disables the frame; the Breeze setting to keep frames around page titles is no longer respected. If this is intended, the frame shouldn't set a background role (and the code would have to be checked regarding correct foreground colors). | |