Add level api from Kirigami.Heading
ClosedPublic

Authored by mart on Nov 27 2018, 4:15 PM.

Details

Summary

add a "level" api that has the same meaning as in the Kirigami Heading component,
This makes easier for QWidget apps to follow the typographi HIG at
D16864 QWidget and QML apps will look more similar and config dialogs
the same.
together other diffs introduces more consistency within SystemSettings
between QWidget and QML based kcms

Test Plan

ran a lot of config dialogs

Diff Detail

Repository
R236 KWidgetsAddons
Branch
phab/heading
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 5422
Build 5440: arc lint + arc unit
mart created this revision.Nov 27 2018, 4:15 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptNov 27 2018, 4:15 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
mart requested review of this revision.Nov 27 2018, 4:15 PM
mart added a comment.Nov 27 2018, 4:16 PM

with a QWidget KCM

In D17190#366840, @mart wrote:

with a QWidget KCM

In those screenshots, "< Fonts" is basically just a named back button. Should it really have the same size and visual weight as the active KCMs' title?

mart added a comment.Nov 27 2018, 4:25 PM

In those screenshots, "< Fonts" is basically just a named back button. Should it really have the same size and visual weight as the active KCMs' title?

I think so, it's the title of what the underlying listview is about, which is "the other kcm you can open now" which should have the same weight as what the current kcm is

that's for D17192 btw

fabianr edited the summary of this revision. (Show Details)Nov 28 2018, 8:36 AM
ngraham accepted this revision.Nov 28 2018, 4:28 PM
This revision is now accepted and ready to land.Nov 28 2018, 4:28 PM
This revision was automatically updated to reflect the committed changes.
cfeck added a subscriber: cfeck.Dec 28 2018, 3:00 AM
cfeck added inline comments.
src/ktitlewidget.cpp
132

Setting 0 margins effectively disables the frame; the Breeze setting to keep frames around page titles is no longer respected.

If this is intended, the frame shouldn't set a background role (and the code would have to be checked regarding correct foreground colors).