use a Kirigami Heading for perfect consistency
Needs ReviewPublic

Authored by mart on Tue, Nov 27, 4:23 PM.

Details

Reviewers
None
Group Reviewers
Plasma
VDG
Summary

Make the title of the submodules column a Kirigami Heading
so that looks the same and is perfectly aligned wuith the KCM title
to make everything look coherent and minimize the number of fonts
shown on the screen at once
depends from D17190 and D17191

Test Plan

loaded a lot of kcms

Diff Detail

Repository
R124 System Settings
Branch
phab/heading
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 5425
Build 5443: arc lint + arc unit
mart created this revision.Tue, Nov 27, 4:23 PM
Restricted Application added a project: Plasma. · View Herald TranscriptTue, Nov 27, 4:23 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart requested review of this revision.Tue, Nov 27, 4:23 PM

I worry that this distorts the UI by giving the back button the same visual weight as the open KCM's title. I'm not categorically against it because I do see the advantage of improving the alignment, but something about it just feels kind of off to me in its current form, like the visual hierarchy is now not quite right.

Perhaps we could just remove the bold effect but keep it the same size as the other entries in the subcategory list?

mart added a comment.Wed, Nov 28, 8:47 AM

anyways, this can wait/can be discussed, the ones instead i would like to get in soonish are D17190 and D17191

I don't really have an issue with the font alignment. I think where I am conflicted is the part where we want this text to have too many purposes. The label is big so as to mean that it is a page title. However, when we place this on a phone, the header text is huge. So the label is trying to be a page title and a breadcrumb. I think that we should rethink the size, at least. The alignment is great.

I agree with @abetts. The alignment changes are great, but I think it's a semantic error to use the title size and style for text that's essentially a glorified back button.

mart added a comment.Thu, Nov 29, 3:34 PM

well, to me part of the problem is that a title became a back button... even tough smaller target to hit, i would have preferred to have a toolbutton followed by a proper title that is just a title

In D17192#368170, @mart wrote:

well, to me part of the problem is that a title became a back button... even tough smaller target to hit, i would have preferred to have a toolbutton followed by a proper title that is just a title

I agree. In my mind we had something like this

TITLE > SUBTITLE > SUBTITLE

Where the > were back buttons

It isn't a title, though. At best, the text in question is a list item, not a title.

I kinda like the fact that the whole item is a button. It even looks button-like. Makes for a nice easy click/touch target, and you know exactly where going back will take you.

mart added a comment.Mon, Dec 3, 9:04 AM

It isn't a title, though. At best, the text in question is a list item, not a title.

It surely is, it's the title of that column and says, this column is stuff about "Fonts", "Workspace theme" etc

I see, you're right!

Finally got to test this out instead of just complaining about the pictures. :) I now have KDeclarative, KCMUtils, and KWidgetsAddons with the necessary changes, but when I compile System Settings with this, I see the following:

With certain KCMs, the sizes don't seem identical:

But with other ones, they do:

I have reservations about how well this larger size will work for wordy languages like German. We already have some strings elided in English:

With this patch, the back button's text just seems, I dunno, too big.