Differential D17095

Fixed comic widget crash
ClosedPublic
Actions

Authored by pavelmos on Nov 22 2018, 9:23 AM.

Details

Reviewers
jriddell
bshah
davidedmundson
mart
Group Reviewers
Plasma
Commits
R114:5b412f94ff39: [comic] Fix error handling in data updated
Summary

Crash happens on trying to load an unsupported format content such as video.
To prevent a crash, the patch blocks the loading of unsupported content (such as video) instead of a picture when switching comic strip.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
pavelmos created this revision.Nov 22 2018, 9:23 AM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 22 2018, 9:23 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
pavelmos requested review of this revision.Nov 22 2018, 9:23 AM
anthonyfieroni added a reviewer: Plasma.Nov 22 2018, 9:30 AM
anthonyfieroni added a subscriber: anthonyfieroni.
anthonyfieroni added inline comments.
applets/comic/comic.cpp
196

Just move this after brace.

pavelmos updated this revision to Diff 45996.Nov 22 2018, 10:06 AM
pavelmos marked an inline comment as done.
pavelmos added inline comments.
applets/comic/comic.cpp
196

Yes, I agree. Your remark is true

mart accepted this revision.Nov 23 2018, 11:11 AM
This revision is now accepted and ready to land.Nov 23 2018, 11:11 AM
pavelmos added a comment.Nov 23 2018, 11:34 AM

I have no commit access.

Closed by commit R114:5b412f94ff39: [comic] Fix error handling in data updated (authored by anthonyfieroni). · Explain WhyNov 25 2018, 3:33 PM
This revision was automatically updated to reflect the committed changes.
ngraham added a subscriber: ngraham.Nov 25 2018, 7:59 PM

@anthonyfieroni these last few patches of Pavel's were landed with your authorship information, not his. In the future let's follow https://community.kde.org/Infrastructure/Phabricator#Landing_someone_else.27s_diff

Thanks!

Revision Contents
Changeset List

PathPackages
Mapplets/comic/comic.cpp (2 lines)

Diff 45996

View Options

applets/comic/comic.cpp

Loading...