Differential D17094

Fixed comic widget context menu crash
ClosedPublic
Actions

Authored by pavelmos on Nov 22 2018, 9:22 AM.

Details

Reviewers
jriddell
bshah
davidedmundson
mart
anthonyfieroni
Commits
R114:ce5bc062fe15: [comic] Fix widget context menu
Summary

Crash happens on trying to use the context menu of widget with no active comics.
The patch disables some items in this context menu to prevent crashes.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
pavelmos created this revision.Nov 22 2018, 9:22 AM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 22 2018, 9:22 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
pavelmos requested review of this revision.Nov 22 2018, 9:22 AM
anthonyfieroni added a subscriber: anthonyfieroni.Nov 22 2018, 11:26 AM
anthonyfieroni added inline comments.
applets/comic/comic.cpp
527

Check against nullptr like else branch?

pavelmos updated this revision to Diff 46064.Nov 23 2018, 8:50 AM
pavelmos marked an inline comment as done.Nov 23 2018, 9:05 AM
mart accepted this revision.Nov 23 2018, 11:12 AM
This revision is now accepted and ready to land.Nov 23 2018, 11:12 AM
pavelmos added a comment.Nov 23 2018, 11:34 AM

I have no commit access.

ngraham added a reviewer: anthonyfieroni.Nov 24 2018, 3:01 PM
ngraham added a subscriber: ngraham.

@anthonyfieroni, if this looks good to you now, would you mind landing it for Pavel? Thanks!

His authorship information is Pavel Mars <mars@basealt.ru>

Closed by commit R114:ce5bc062fe15: [comic] Fix widget context menu (authored by anthonyfieroni). · Explain WhyNov 25 2018, 3:33 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mapplets/comic/comic.h (2 lines)
Mapplets/comic/comic.cpp (49 lines)

Diff 46064

View Options

applets/comic/comic.h

Loading...
View Options

applets/comic/comic.cpp

Loading...