Diff Detail
- Repository
- R119 Plasma Desktop
- Branch
- kickoff-visible-and-unfocused-tab-esc (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 5169 Build 5187: arc lint + arc unit
I appreciate the effort to split up a big commit, but this isn't quite right.
There's duplicated code changes both here and in https://phabricator.kde.org/D17020
| applets/kickoff/package/contents/ui/Header.qml | ||
|---|---|---|
| 285 ↗ | (On Diff #45825) | it's very unusual to not move the actual focus on tab. |
AH now I get it, they ought to be designed as patches for D16988 as though it were master. My bad.
| applets/kickoff/package/contents/ui/Header.qml | ||
|---|---|---|
| 285 ↗ | (On Diff #45825) | Sorry about that - I'm totally new to this so the only way I could figure out how to keep activeFocusOnTab: false in hintLabel was to use this Keys.onPressed --> query thing. I placed activeFocusOnTab: false in hintLabel because the tab key kept selecting the label instead of the search box (it did not look pretty). Using activeFocusOnTab in queryField doesn't seem to do anything once activeFocusOnTab: false has been set in hintLabel. Do you know of any other way to resolve this? |