Differential D17022

[Kickoff] Enable Esc to close Kickoff and Tab to switch to Search
AbandonedPublic
Actions

Authored by rooty on Nov 19 2018, 5:13 PM.

Details

Reviewers
ngraham
romangg
Summary

Depends on D16988

This patch collapses Kickoff when Esc is pressed, as well as enables the user to use Tab to focus the search field.

Included commits in branch kickoff-visible-and-unfocused-tab-esc:
63c6197a151a [Kickoff] Depends on D16988, Enable Esc to close Kickoff and Tab to switch to Search

Diff Detail

Repository
R119 Plasma Desktop
Branch
kickoff-visible-and-unfocused-tab-esc (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 5169
Build 5187: arc lint + arc unit
rooty created this revision.Nov 19 2018, 5:13 PM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 19 2018, 5:13 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
rooty requested review of this revision.Nov 19 2018, 5:13 PM
rooty edited the summary of this revision. (Show Details)Nov 19 2018, 5:14 PM
rooty added reviewers: ngraham, romangg.
rooty retitled this revision from [Kickoff] Depends on D16988, Enable Esc to close Kickoff and Tab to switch to Search to [Kickoff] Enable Esc to close Kickoff and Tab to switch to Search.Nov 19 2018, 6:02 PM
rooty edited the summary of this revision. (Show Details)
davidedmundson added a subscriber: davidedmundson.Nov 20 2018, 8:49 AM

I appreciate the effort to split up a big commit, but this isn't quite right.

There's duplicated code changes both here and in https://phabricator.kde.org/D17020

applets/kickoff/package/contents/ui/Header.qml
316

it's very unusual to not move the actual focus on tab.

rooty added a comment.Nov 20 2018, 9:03 AM
In D17022#362813, @davidedmundson wrote:

I appreciate the effort to split up a big commit, but this isn't quite right.

There's duplicated code changes both here and in https://phabricator.kde.org/D17020

AH now I get it, they ought to be designed as patches for D16988 as though it were master. My bad.

applets/kickoff/package/contents/ui/Header.qml
316

Sorry about that - I'm totally new to this so the only way I could figure out how to keep activeFocusOnTab: false in hintLabel was to use this Keys.onPressed --> query thing.

I placed activeFocusOnTab: false in hintLabel because the tab key kept selecting the label instead of the search box (it did not look pretty).

Using activeFocusOnTab in queryField doesn't seem to do anything once activeFocusOnTab: false has been set in hintLabel.

Do you know of any other way to resolve this?

rooty updated this revision to Diff 45868.Nov 20 2018, 9:14 AM
filipf added a subscriber: filipf.Nov 22 2018, 8:27 PM
rooty added a comment.Jan 2 2019, 11:32 PM
This comment was removed by rooty.
rooty abandoned this revision.Jan 2 2019, 11:33 PM

Abandoned because of parent (D16988).

abetts added a comment.Jan 3 2019, 3:46 PM

Love it! IDK how it wasn't implemented already!

Revision Contents
Changeset List

Diff 45868

View Options

applets/kickoff/package/contents/ui/Header.qml

Loading...