I noticed this while porting from qqc1 to qqc2 for Elisa, as the qqc2 ToolButton did not behave as expected. Neither qqc1 version nor the Fusion style display a text for a ToolButtons.
I don't know the reason why this was added and also have no clue about the implications this change may have in case some apps rely on that behavior.

opinions?

Wouldn't this change make it revert to the default value, which is Qt::ToolButtonIconOnly? How about Qt::ToolButtonFollowStyle instead? That way it'll pick up the user-overridable setting in the style KCM.

@mgallien stated in the meantime that we probably have been abusing the ToolButton in Elisa for our needs, and we will go a different route anyway.
Since the desktop style still behaves differently than QQC1 and the Fusion style, I think it's still of value to discuss this. I will just follow your call here, tell me what the right solution is :)

To me, using Qt::ToolButtonFollowStyle would seem to make sense, but it might be best to ask @mart or @hein, who may know more of the history behind why Qt::ToolButtonTextBesideIcon was chosen here in the first place.

friendly ping