I tried and it didn't worked for some reason

Em ter, 25 de set de 2018 às 13:37, Anthony Fieroni <
noreply@phabricator.kde.org> escreveu:

anthonyfieroni added inline comments. View Revision
https://phabricator.kde.org/D15742
*INLINE COMMENTS*
View Inline https://phabricator.kde.org/D15742#inline-85071
ViewContainer.cpp:92-93
this, &TabbedViewContainer::closeTerminalTab);
connect(tabBarWidget, &DetachableTabBar::newTabRequest,
this, [this]{ emit newViewRequest(); });

You can connect directly the two signals.

*REPOSITORY*
R319 Konsole

*REVISION DETAIL*
https://phabricator.kde.org/D15742

*To: *tcanabrava, ngraham, hindenburg
*Cc: *anthonyfieroni, konsole-devel, herrold, ngraham, maximilianocuria,
hindenburg

Ok, I'll update the patch

Em ter, 25 de set de 2018 às 13:50, Kai Uwe Broulik <
noreply@phabricator.kde.org> escreveu:

broulik added inline comments. View Revision
https://phabricator.kde.org/D15742
*INLINE COMMENTS*
View Inline https://phabricator.kde.org/D15742#inline-85072
DetachableTabBar.cpp:61
_containers = window()->findChildren<Konsole::TabbedViewContainer*>();
switch(event->button()) {
case Qt::MiddleButton : middleMouseButtonClickAt(event->pos()); break;
case Qt::LeftButton: _containers = window()->findChildren<Konsole::
TabbedViewContainer*>(); break;

Tabs typically close on mouse *release*.

*REPOSITORY*
R319 Konsole

*REVISION DETAIL*
https://phabricator.kde.org/D15742

*To: *tcanabrava, ngraham, hindenburg
*Cc: *broulik, anthonyfieroni, konsole-devel, herrold, ngraham,
maximilianocuria, hindenburg

I really dislike the middle click tab = close tab; we don't want to provide an easy accidentally way to close tabs IMHO.

I don't think we need to mimic all of browsers habits, especially since browser have a "tab history" and a way to reopen recently closed browsers.

To be honest, I'm not the biggest fan either, but I think consistency is important here.

An "undo close tab" feature would be a really fantastic addition though.

In D15742#332126, @ngraham wrote:

An "undo close tab" feature would be a really fantastic addition though.

It can be tough to impossible, in terminal you can make many things, it's not that easy like in browser, ssh, long standing web servers, logins etc. For security reasons it can be dangerous, handle a copy of terminal session can be harmful, passwords in plain text, etc so better not go in such direction.

Unless you want to add another option for this, with default as-it, I'll veto the close tab click. I don't see an issue w/ the new tab part.

In D15742#332626, @hindenburg wrote:

Unless you want to add another option for this, with default as-it, I'll veto the close tab click. I don't see an issue w/ the new tab part.

ok, I'll update just for the open tab.
the other possibility is to first time you middle click at the tab there's a MessageBox explaining what happened and with the middle click and asking the person to opt-in / out.

Are you still planning on working on this to just have the middle-click to open a new tab?

@tcanabrava Are you still working on this, because I did not knew about this revision and created a new revision for the same feature
Please see D18606

I'll close this one, let's use yours.

This one works for me - the other doesn't

geh, then let's keep this one and remove the other one.

can you reopen this pls? we need to add a GUI option to disable the closing part.

@tcanabrava If you don't mind, can I take over this revision? I'm willing to complete it.

Be my guest

Em qua, 13 de fev de 2019 às 08:48, Shubham <noreply@phabricator.kde.org>
escreveu:

shubham added a comment. View Revision
https://phabricator.kde.org/D15742

@tcanabrava https://phabricator.kde.org/p/tcanabrava/ If you don't
mind, can I commander this revision?

*REPOSITORY*
R319 Konsole

*REVISION DETAIL*
https://phabricator.kde.org/D15742

*To: *tcanabrava, ngraham, hindenburg
*Cc: *thsurrel, ngraham, hindenburg, shubham, broulik, anthonyfieroni,
konsole-devel, gennad, maciejn, maximilianocuria

@hindenburg @ngraham Friendly Ping

Thanks I'll look at this weekend

However I just noticed this patch has the wrong bug number. 361756 is for Okular. The Konsole bug is 398940, but it should be a CCBUG: not a BUG: because that report also requests the feature of middle-clicking in empty areas of the tab bar to create new tabs.

...Unless you want to implement that, too. :)

because that report also requests the feature of middle-clicking in empty areas of the tab bar to create new tabs.
...Unless you want to implement that, too. :)

I think it is not required, because we would be just duplicating the double click behaviour then. Currently double click does this.

The code actually closes when on a tab and opens a new tab when over an empty space. You'll need to update the message and GUI text.

Also if you can, rebase this diff on master as it is using a very old commit.

https://secure.phabricator.com/w/guides/arcanist_workflows/

I can't get middle-click-in-empty-space-to-open-a-new-tab to work with this patch. Double-clicking currently does this, but for me this patch doesn't add that behavior.

In D15742#413810, @ngraham wrote:

I can't get middle-click-in-empty-space-to-open-a-new-tab to work with this patch. Double-clicking currently does this, but for me this patch doesn't add that behavior.

It does here - can you double-check? Are you suing a real middle mouse or trackpad (not sure that matters, just asking)?

I can confirm that middle click on empty portion of the bar creates a new tab.

what should I now name the gui message? It will become quite big then.

In D15742#414002, @shubham wrote:

what should I now name the gui message? It will become quite big then.

There's quite a lot of space there, it can be two lines if needed - perhaps "Allow middle click to close and create new tabs"

Another idea: always allow middle-click to open new tabs, but just have the option toggle its close behavior. Then the string can be nice and simple.

In D15742#414238, @ngraham wrote:

Another idea: always allow middle-click to open new tabs, but just have the option toggle its close behavior. Then the string can be nice and simple.

Oh yes, I forgot we had agreed on that.

Looks like a few git conflict markers have made their way in the code.

Yes, noticed, going to fix in a moment

@emateli do you know how can I go to previous version I have uploaded?

yea give me a few

Nice job, @shubham. Wanna do the same thing for Okular next? https://bugs.kde.org/show_bug.cgi?id=361756. Probably doesn't need an option there.

In D15742#415891, @ngraham wrote:

Nice job, @shubham. Wanna do the same thing for Okular next? https://bugs.kde.org/show_bug.cgi?id=361756. Probably doesn't need an option there.

Actually yes, coz I m targeting okular for past few days, you might be knowing.