Simlink the following
16 -> 16@2x
22 -> 22@2x
I think the suffix should be @2x, not just @2. Also, I don't think it's neccessary for the animation folder.
Anyway, without the ScalableIcons entry in index.theme testing this is difficult
That would be easy to change, I didn't add to the index.theme because i was not sure what i needed to add . If someone could advise me i will update that when i change the link to '16@2x'
Should I be doing this for all the size folders or just 16? what about emblems where i think 8 is our small size?
About the index.theme, what you want to do is, for every folder duplicate the non-2x entry and add a Scale=2 to it, e.g.
[places/16] Size=16 Context=Places Type=Fixed
add after it
[places/16@2x] Size=16 Scale=2 Context=Places Type=Fixed
and also add all the new directories to a ScaledDirectories key, below Directories (it is a separate key so that applications not supporting this don't get confused by the new scaled directories)
Thanks a lot!
There's a quirk in Dolphin where it wouldn't pick up the 22px places icons as in KStandardItemListWidget::pixmapForIcon it scales the size (22→44) first and then clamps it to an icon size (48) and so it won't find the fixed 22. Also, the problem of highlighted files turning white. I'd like to investigate those two issues before we merge this. Your patch looks good, however! :)
So if I apply this patch, use a 2x scale factor, and launch Dolphin (from 18.08.2 or git master), I should see all line-art icons in my places panel, right? It works for 2x, and 1.5x, but at 1.7x and 1.3x I hit https://bugs.kde.org/show_bug.cgi?id=396990. But that's not your fault, so... approved!
Does this mean that every new 16px, 22px, 24px, and 32px monochrome icon will need an @2x symlink?