I think the suffix should be @2x, not just @2. Also, I don't think it's neccessary for the animation folder.
Anyway, without the ScalableIcons entry in index.theme testing this is difficult

In D15213#319039, @broulik wrote:

I think the suffix should be @2x, not just @2. Also, I don't think it's neccessary for the animation folder.
Anyway, without the ScalableIcons entry in index.theme testing this is difficult

That would be easy to change, I didn't add to the index.theme because i was not sure what i needed to add . If someone could advise me i will update that when i change the link to '16@2x'

Should I be doing this for all the size folders or just 16? what about emblems where i think 8 is our small size?

About the index.theme, what you want to do is, for every folder duplicate the non-2x entry and add a Scale=2 to it, e.g.

[places/16]
Size=16
Context=Places
Type=Fixed

add after it

[places/16@2x]
Size=16
Scale=2
Context=Places
Type=Fixed

and also add all the new directories to a ScaledDirectories key, below Directories (it is a separate key so that applications not supporting this don't get confused by the new scaled directories)

Thanks a lot!

There's a quirk in Dolphin where it wouldn't pick up the 22px places icons as in KStandardItemListWidget::pixmapForIcon it scales the size (22→44) first and then clamps it to an icon size (48) and so it won't find the fixed 22. Also, the problem of highlighted files turning white. I'd like to investigate those two issues before we merge this. Your patch looks good, however! :)

In D15213#321121, @ngraham wrote:

Does this mean that every new 16px, 22px, 24px, and 32px monochrome icon will need an @2x symlink?

There will be no need for that since I have simlinked the directories using ln -sdr so 16@2x is a simlink to 16. No icons links were created.

Fantastic, shipit!

I love all of these HIDPI fixes lately.

Did this fix bug 398094?

Hah, yes it did!