[recentdocuments:/] Filter out files that can't be browsed with a file manager
ClosedPublic
Actions

Authored by ngraham on Aug 16 2018, 10:30 PM.

Details

Reviewers

Group Reviewers

Dolphin
Frameworks

Maniphest Tasks

T8349: Improve Places panel usability and presentation

Commits

R320:8606d4d97f3e: [recentdocuments:/] Filter out files that can't be browsed with a file manager

Summary

This is a more appropriate version of D13797: Only add actual documents to Recent Documents. Basically we filter out anything that can't be browsed with a file manager, such as web linkns, appstream:// urls, etc.

This ensures that the contents of the recentdocuments:/ ioslave is relevant to the user.

Test Plan

Opened a link from Spectacle in my web browser. Without the patch, it shows up in recentdocuments:/. With the patch, it does not.

Diff Detail

Repository

R320 KIO Extras

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

ngraham requested review of this revision.Aug 16 2018, 10:30 PM

ngraham created this revision.

Harbormaster completed remote builds in B1933: Diff 39892.Aug 16 2018, 10:30 PM

ngraham mentioned this in D13797: Only add actual documents to Recent Documents.Aug 16 2018, 10:31 PM

It "looks" oke to me, but i don't know this code one bit.

recentdocuments/recentdocuments.cpp
82–83	Comments inside a multi-line if statement! Unheard of! Please move that to a more appropriate place.

ngraham marked an inline comment as done.Aug 20 2018, 1:56 PM

Move comment

Harbormaster completed remote builds in B2022: Diff 40054.Aug 20 2018, 1:57 PM

In D14893#311411, @markg wrote:

It "looks" oke to me, but i don't know this code one bit.

Give it a try, it's pretty easy to test with the test plan.

+1, lgtm

This revision was not accepted when it landed; it landed in state Needs Review.Aug 20 2018, 7:12 PM

Closed by commit R320:8606d4d97f3e: [recentdocuments:/] Filter out files that can't be browsed with a file manager (authored by ngraham). · Explain Why

This revision was automatically updated to reflect the committed changes.

ngraham mentioned this in D7446: [Places panel] Revamp the Recently Saved section.Sep 25 2018, 2:40 AM

ngraham added a task: T8349: Improve Places panel usability and presentation.

Restricted Application added projects: Dolphin, Frameworks. · View Herald TranscriptSep 25 2018, 2:41 AM

Restricted Application added subscribers: kfm-devel, kde-frameworks-devel. · View Herald Transcript

ngraham mentioned this in T8349: Improve Places panel usability and presentation.Sep 25 2018, 2:43 AM

Revision Contents
Changeset List

			Path	Packages
M			recentdocuments/recentdocuments.cpp (8 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	39892	1e44637		Aug 16 2018, 10:30 PM	★	★
Diff 2	40054	1e44637	Move comment	Aug 20 2018, 1:56 PM	★	★
Diff 3	40074	5907992	R320:8606d4d97f3e2cf77e3fe58fac62563695f1a2a3	Aug 20 2018, 7:06 PM	★	★

Diff 40074

View Options

recentdocuments/recentdocuments.cpp