This is the patch file for Note_names activity to be submitted for final evaluation of GSoC.
Details
- Reviewers
jjazeix - Group Reviewers
GCompris: Activities - Maniphest Tasks
- T1520: Port of the Gtk+ note names activity
Diff Detail
- Repository
- R2 GCompris
- Lint
Lint Skipped - Unit
Unit Tests Skipped
src/activities/note_names/AdvancedTimer.qml | ||
---|---|---|
22 | 2.6 | |
src/activities/note_names/NoteNames.qml | ||
54 | code should be factorised | |
58 | why Z? Isn't there a cleaner way to have an error? | |
241 | need a translator comment to understand the string | |
314 | should have a better id than piano2. | |
342 | shouldn't it be bar_previous? | |
src/activities/note_names/note_names.js | ||
23 | version | |
44 | you should never use += for appending strings as the order can change depending on the language. | |
60 | first compute items.background.clefType and use it in items.piano.coloredKeyLabels | |
88 | hardcoded 25, 50 is not good | |
126 | 4 is harcoded | |
137 | hardcode |
src/activities/note_names/NoteNames.qml | ||
---|---|---|
281 | I have a problem when I want to play a B3. I should have two keyboards present on the screen. C3-B3 keyboard under C4-B4, I can this way play a C4 and B3 without using the arrows. At the moment I have just the C3-B3 alone on the top position and this is not playable. Same problem in horizontal mode where I have only C3-B3 on the right of the screen. I should see the two octaves C3-B3 and C4-B4. | |
284 | It would be good to rename Piano element as PianoOctaveKeyboard | |
363 | can you try to make the arrows bigger and put them over the keyboard, you gain some place to extend the size of the keyboardon the left and on the right, bigger the keys will be better it will be. |
src/activities/note_names/NoteNames.qml | ||
---|---|---|
363 | Yes above. Three is enough Place. |
src/activities/note_names/ActivityInfo.qml | ||
---|---|---|
33 | just leave it empty if none is needed | |
src/activities/note_names/NoteNames.qml | ||
53 | you can use a map of <Qt.Key_*, key> to simplify more | |
241 | you can just say it's a percentage, translators won't know what is parent.value | |
src/activities/note_names/resource/dataset_01.qml | ||
23 | version |