2.6

code should be factorised

why Z? Isn't there a cleaner way to have an error?

need a translator comment to understand the string

should have a better id than piano2.
And a comment to tell why you need 2 pianos, and not only one.
Can using a Repeater here be better?

shouldn't it be bar_previous?

version

you should never use += for appending strings as the order can change depending on the language.

first compute items.background.clefType and use it in items.piano.coloredKeyLabels

hardcoded 25, 50 is not good

4 is harcoded

hardcode

1.5

can it be an alias of the value?

it still needs qsTr(). In French, there is a space between the number and the %

I have a problem when I want to play a B3. I should have two keyboards present on the screen. C3-B3 keyboard under C4-B4, I can this way play a C4 and B3 without using the arrows. At the moment I have just the C3-B3 alone on the top position and this is not playable.

Same problem in horizontal mode where I have only C3-B3 on the right of the screen. I should see the two octaves C3-B3 and C4-B4.

It would be good to rename Piano element as PianoOctaveKeyboard

can you try to make the arrows bigger and put them over the keyboard, you gain some place to extend the size of the keyboardon the left and on the right, bigger the keys will be better it will be.

I had tried but it doesn't allow.

you mean above the keyboard?

Yes above. Three is enough Place.

just leave it empty if none is needed

you can use a map of <Qt.Key_*, key> to simplify more

you can just say it's a percentage, translators won't know what is parent.value

version