This is the patch file for Note_names activity to be submitted for final evaluation of GSoC.
|21 ↗||(On Diff #39201)|
code should be factorised
why Z? Isn't there a cleaner way to have an error?
need a translator comment to understand the string
should have a better id than piano2.
shouldn't it be bar_previous?
|22 ↗||(On Diff #39201)|
|43 ↗||(On Diff #39201)|
you should never use += for appending strings as the order can change depending on the language.
|59 ↗||(On Diff #39201)|
first compute items.background.clefType and use it in items.piano.coloredKeyLabels
|87 ↗||(On Diff #39201)|
hardcoded 25, 50 is not good
|125 ↗||(On Diff #39201)|
4 is harcoded
|136 ↗||(On Diff #39201)|
I have a problem when I want to play a B3. I should have two keyboards present on the screen. C3-B3 keyboard under C4-B4, I can this way play a C4 and B3 without using the arrows. At the moment I have just the C3-B3 alone on the top position and this is not playable.
It would be good to rename Piano element as PianoOctaveKeyboard
can you try to make the arrows bigger and put them over the keyboard, you gain some place to extend the size of the keyboardon the left and on the right, bigger the keys will be better it will be.
|33 ↗||(On Diff #39445)|
just leave it empty if none is needed
you can use a map of <Qt.Key_*, key> to simplify more
you can just say it's a percentage, translators won't know what is parent.value
|23 ↗||(On Diff #39445)|