This regression (compared to kdelibs4's direct KFileDialog usage) came
from the fact that QFileDialog's lastVisited() only gets updated if
the helper emits directoryEntered.
So QFileDialog was setting the current dir as startDir every single
time, overriding's KFileWidget's own logic for reusing the last dir
initially.
QFileDialog::getOpenFileName(this, i18n("Select file"));
twice in a row, from the same process.
| No Linters Available |
| No Unit Test Coverage |
| Buildable 1314 | |
| Build 1332: arc lint + arc unit |
| src/platformtheme/kdeplatformfiledialoghelper.cpp | ||
|---|---|---|
| 118 | I'm not sure I understand the comment. Is it like a TODO? | |
| src/platformtheme/kdeplatformfiledialoghelper.cpp | ||
|---|---|---|
| 118 | It works without comment, i think these connections are not needed. | |
| src/platformtheme/kdeplatformfiledialoghelper.cpp | ||
|---|---|---|
| 118 | Yes for this problem my patch is enough, but I was surprised to find that those signals were not connected. Yes it's a TODO, but unrelated to this bug. | |
+1 from me on the patch.
I'd prefer without the comment and just have it investigated, I'm not sure the comment will help.
Remove TODO comment. Although I can say it would have definitely helped me when investigating this bug...
+1, this fixes a really annoying issue I had in LibreOffice (https://bugs.documentfoundation.org/show_bug.cgi?id=104192) and doesn't seem to regress the location behavior at all.
FWIW this works fine for me on the 5.12 branch; might be nice to get it there too for LTS users.