I tried the patch and it doesn't make a difference here, the mountpoint of my NTFS partition is still hidden.
(it's on an internal drive and mounted to /windows/C via fstab in case it matters)

Additional debug output showed that ep->d_type is not DT_DIR but 0 (which would be DT_UNKNOWN IIANM?) in my case.

In D13782#287336, @wbauer wrote:

I tried the patch and it doesn't make a difference here, the mountpoint of my NTFS partition is still hidden.
(it's on an internal drive and mounted to /windows/C via fstab in case it matters)

Additional debug output showed that ep->d_type is not DT_DIR but 0 (which would be DT_UNKNOWN IIANM?) in my case.

It does seem to matter.
I just created an NTFS partition on an USB stick, mounted it via dolphin (to /run/media/...) and in this case ep->d_type is indeed DT_DIR, the patch works as intended in this case.

So maybe you should check for DT_UNKNOWN as well...

Ping

In D13782#296381, @ngraham wrote:

@wbauer, does this work for you now?

Yes, it does work as expected now here in all cases I tested, and I didn't notice problems.

With additional debug output I do see the '.' entry in the root dir still marked as hidden (as mentioned in the test plan), and also the '..' entry in (first-level) subdirs is hidden.
This could be fixed e.g. by using QDir::cleanPath(), i.e.:

const QString fullFilePath = QDir::cleanPath(path + QLatin1Char('/') + filename);

But I'm not sure that is really necessary as those entries are not displayed at all anyway (even with hidden files enabled).

In D13782#297547, @wbauer wrote:

With additional debug output I do see the '.' entry in the root dir still marked as hidden (as mentioned in the test plan), and also the '..' entry in (first-level) subdirs is hidden.

I also found another problem though: symlinks to the mountpoint/NTFS root dir are (still) hidden as well (also if they are on different partitions).

Using QDir::canonicalPath() (instead of QDir::cleanPath() ) would fix all 3 cases:

const QString fullFilePath = QDir(path + QLatin1Char('/') + filename).canonicalPath();

(that one isn't static...)

In D13782#297639, @wbauer wrote:

Using QDir::canonicalPath() (instead of QDir::cleanPath() ) would fix all 3 cases:

const QString fullFilePath = QDir(path + QLatin1Char('/') + filename).canonicalPath();

Or rather, as the current directory is set to path in line#507, this would actually suffice:

const QString fullFilePath = QDir(filename).canonicalPath();

I cannot speak for the code, but this seems to work perfectly well when I tested it today. I used Kate and KBackup to open some files/directories on an external NTFS, and used KBackup to write a backup to the drive. I didn't have to check 'Show hidden folders' and the device shortcut for the NTFS drive in the Open dialog worked as expected.
I hope this can be pushed soon.

@broulik? Is it ready to land?