Fix NTFS hidden check for symlinks to NTFS mountpoints
ClosedPublic
Actions

Authored by wbauer on Jan 23 2019, 6:40 PM.

Details

Reviewers

Group Reviewers

Frameworks
Dolphin

Commits

R241:01a7e0e757d3: Fix NTFS hidden check for symlinks to NTFS mountpoints

Summary

A symlink to the mountpoint of an NTFS partition can have the type DT_LNK.
So extend the check to cover that case as well.

BUG: 402738

Test Plan

Create a symlink to an NTFS mountpoint.
Open dolphin and browse to the folder containing the symlink.

It is not hidden anymore.

Diff Detail

Repository

R241 KIO

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

wbauer created this revision.Jan 23 2019, 6:40 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptJan 23 2019, 6:40 PM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

The existing check did work fine for me back in D13782 also for symlinks for some reason.
Maybe this broke because of some change in the kernel or glibc? :-/

In D18479#398655, @wbauer wrote:

The existing check did work fine for me back in D13782 also for symlinks for some reason.
Maybe this broke because of some change in the kernel or glibc? :-/

I assume the symlink had the type of the target back then (on my systems at least), and that has been fixed meanwhile...

ngraham added a reviewer: Dolphin.Jan 23 2019, 10:28 PM

Ping?

ngraham accepted this revision.Mar 2 2019, 10:08 PM

This revision is now accepted and ready to land.Mar 2 2019, 10:08 PM

Closed by commit R241:01a7e0e757d3: Fix NTFS hidden check for symlinks to NTFS mountpoints (authored by wbauer). · Explain WhyMar 3 2019, 11:55 AM

This revision was automatically updated to reflect the committed changes.