Display "No Borders" by default

Authored by davidedmundson on Jun 2 2018, 1:36 AM.


Group Reviewers

Turns off visible window borders by default, as discussed exhaustively in T8707: Window borders. I would prefer not to rehash the discussion that we had there, if possible.

BUG: 315400
Fixed-IN: 5.14

Closes T8707

Test Plan
  • Window borders are off by default with a new user account
  • The Border Size Combobox in KWin's Window Decorations KCM has the correct value in it and still works to change the value
  • Resetting KWin Window Decoration settings to default values results in "No Borders" being used

Diff Detail

R108 KWin
no-borders-by-default (branched from master)
No Linters Available
No Unit Test Coverage
ngraham created this revision.Jun 2 2018, 1:36 AM
Restricted Application added a project: KWin. · View Herald TranscriptJun 2 2018, 1:36 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
ngraham requested review of this revision.Jun 2 2018, 1:36 AM
abetts accepted this revision.Jun 2 2018, 1:39 AM
This revision is now accepted and ready to land.Jun 2 2018, 1:39 AM
davidedmundson added inline comments.

That variable name is misleading. Especially on line 224.

Renaming as border size default might be better

ngraham updated this revision to Diff 35380.Jun 2 2018, 2:37 AM

Don't use re-use the existing variable name, because it becomes misleading

ngraham marked an inline comment as done.Jun 2 2018, 2:42 AM
ngraham edited the summary of this revision. (Show Details)Jun 2 2018, 3:10 AM
graesslin requested changes to this revision.Jun 2 2018, 6:08 AM
graesslin added a subscriber: graesslin.

As indicated in the discussion on the task I'm against this change.

This revision now requires changes to proceed.Jun 2 2018, 6:08 AM

As indicated in the discussion on the task I'm against this change.

As also indicated in the task, I too am against this change, but the reasons I put forward were essentially ignored (leading to me not following the task any more).
Feel free to push without my ascent, and if this is a problem, remove me as a reviewer.



This comment was removed by hpereiradacosta.
Fuchs added a subscriber: Fuchs.Jun 2 2018, 11:12 AM
davidedmundson commandeered this revision.Jun 4 2018, 6:30 PM
davidedmundson added a reviewer: ngraham.

Nate, if something is currently under clearly active discussion being pushy will not help drive things forwards. This was extremely tactless.

davidedmundson abandoned this revision.Jun 4 2018, 6:30 PM

My sincere apologies to all involved. I had misread the situation in T8707. I have a bad tendency to argue and push rather than stop and listen when I feel resistance, and I will work much harder to keep that in check. Sorry for the mess. :(