Differential D11184

use the terminal color scheme for the scrollbar
ClosedPublic
Actions

Authored by mart on Mar 9 2018, 4:02 PM.

Details

Reviewers
hindenburg
Group Reviewers
Konsole
VDG
Commits
R319:2a71f063f880: use the terminal color scheme for the scrollbar
Summary

As discussed with VDG, color the scrollbar with the same colors as
the terminal color scheme itself. It looks way cleaner and modern

Test Plan

tested with several color schemes and several styles

Diff Detail

Repository
R319 Konsole
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mart created this revision.Mar 9 2018, 4:02 PM
Restricted Application added a project: Konsole. · View Herald TranscriptMar 9 2018, 4:02 PM
mart requested review of this revision.Mar 9 2018, 4:02 PM
zzag added a subscriber: zzag.Mar 9 2018, 4:21 PM
hindenburg accepted this revision.Mar 10 2018, 3:09 AM
hindenburg added a subscriber: hindenburg.

looks fine thanks

This revision is now accepted and ready to land.Mar 10 2018, 3:09 AM
ngraham accepted this revision as: VDG.Mar 10 2018, 3:58 AM
Closed by commit R319:2a71f063f880: use the terminal color scheme for the scrollbar (authored by mart, committed by hindenburg). · Explain WhyMar 10 2018, 3:58 PM
This revision was automatically updated to reflect the committed changes.
hindenburg added a comment.Mar 17 2018, 4:00 AM

Do you time to look at https://bugs.kde.org/show_bug.cgi?id=391788 ?

Also, I note that there's one "_scrollBar->setPalette(QApplication::palette());" still in TerminalDisplay.cpp; should that be changed to updateScrollBarPalette()?

Revision Contents
Changeset List

PathPackages
Msrc/TerminalDisplay.h (2 lines)
Msrc/TerminalDisplay.cpp (27 lines)

Diff 29168

View Options

src/TerminalDisplay.h

Loading...
View Options

src/TerminalDisplay.cpp

Loading...