use the terminal color scheme for the scrollbar

Authored by mart on Mar 10 2018, 3:57 PM.

Description

use the terminal color scheme for the scrollbar

Summary:
As discussed with VDG, color the scrollbar with the same colors as
the terminal color scheme itself. It looks way cleaner and modern

Test Plan: tested with several color schemes and several styles

Reviewers: Konsole, VDG, hindenburg

Reviewed By: Konsole, VDG, hindenburg

Subscribers: hindenburg, zzag, ngraham

Tags: Konsole

Differential Revision: https://phabricator.kde.org/D11184

Details

Committed
hindenburgMar 10 2018, 3:58 PM
Reviewer
Konsole
Differential Revision
D11184: use the terminal color scheme for the scrollbar
Parents
R319:b85c469efc60: Check for valid session when detaching to prevent crashes
Branches
Unknown
Tags
Unknown

As discussed with VDG, color the scrollbar with the same colors as the terminal color scheme itself. It looks way cleaner and modern

The scroll bar now looks different from all other scroll bars in KDE (as far as I can see), because they use the system-wide color setting.

Whether something is cleaner or modern is obviously subjective. I understand the appeal of this decision, but I can't bring myself to like it. Since there is no clear separation of text and scroll bar, I can't see where a line ends. This results in lines being broken although it looks like there is still space left. GNOME's terminal is different here, because the scroll bar is on top of the text, not next to it. That makes complete sense! But now lines end in the middle of nowhere.

I'm not saying it is wrong, but maybe other people want a more consistent style. If we want to introduce an inconsistency with the rest of KDE here, we should at least make it a setting.

If the VDG decision is to let scroll bars blend in with the content, then they should be above the content as in GNOME.

/src/TerminalDisplay.cpp
791–794

Why does this reasoning not apply any longer?