Differential D11839

Fixed scrollbar background bug for transparent Konsole
ClosedPublic
Actions

Authored by anemeth on Mar 31 2018, 4:58 PM.

Details

Reviewers
hindenburg
Group Reviewers
Konsole
Commits
R319:419a3fa0dea9: Fixed scrollbar background bug for transparent Konsole
R319:88b9cf197f8d: Fixed scrollbar background bug for transparent Konsole
Summary

In D11184 a visual glitch was introduced when using transparent
background in Konsole.

BUG: 391788
FIXED-IN: 18.04

Test Plan

Before:

Opaque, there was no problem here

Transparent, obvious problem

After:

Opaque, nothing changes here

Transparent, problem fixed

Diff Detail

Repository
R319 Konsole
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
anemeth created this revision.Mar 31 2018, 4:58 PM
Restricted Application added a project: Konsole. · View Herald TranscriptMar 31 2018, 4:58 PM
Restricted Application added a subscriber: Konsole. · View Herald Transcript
anemeth requested review of this revision.Mar 31 2018, 4:58 PM
anemeth retitled this revision from Fixed scrollbar background bug to Fixed scrollbar background bug for transparent Konsole.Mar 31 2018, 5:09 PM
anemeth edited the summary of this revision. (Show Details)
anemeth edited the test plan for this revision. (Show Details)
anemeth added reviewers: hindenburg, Konsole.
hindenburg edited the summary of this revision. (Show Details)Apr 1 2018, 3:40 PM
hindenburg accepted this revision.Apr 1 2018, 3:44 PM

Thanks a lot - looks great

This revision is now accepted and ready to land.Apr 1 2018, 3:44 PM
Closed by commit R319:88b9cf197f8d: Fixed scrollbar background bug for transparent Konsole (authored by anemeth, committed by hindenburg). · Explain WhyApr 1 2018, 3:47 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/TerminalDisplay.cpp (16 lines)

Diff 31100

View Options

src/TerminalDisplay.cpp

Loading...