Fix "Moving the mouse over a different application icon immediately changes the window list"
Changes PlannedPublic

Authored by ngraham on Feb 4 2018, 7:19 PM.

Details

Summary

This patch changes the behaviour of opening applications with multiple windows open in the icons-only task manager. Currently, accidentally mousing over another open application steals focus and closes the thumbnail view. This patch amends that.

CCBUG: 358930

Test Plan

*Review patches

Diff Detail

Repository
R242 Plasma Framework (Library)
Branch
arcpatch-D10305
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6583
Build 6601: arc lint + arc unit
lshoravi created this revision.Feb 4 2018, 7:19 PM
Restricted Application added a subscriber: plasma-devel. · View Herald TranscriptFeb 4 2018, 7:19 PM
lshoravi requested review of this revision.Feb 4 2018, 7:19 PM
lshoravi edited the summary of this revision. (Show Details)
lshoravi edited the summary of this revision. (Show Details)Feb 4 2018, 7:22 PM
ngraham added a subscriber: ngraham.

Thanks for doing this! A few notes:

  • Put "CCBUG: 358930" on its own line in the Summary; this will cause the commit to show up in that biug, without closing it.
  • No need to mention the bug number in the title (which becomes the commit message).
  • The title should be something different from D10304; maybe mention that this adds support in the framework
  • You'll want to mark Réne as the author; to do this, first do git commit --amend --author=" René Fürst <rene@fuerst.biz>" and then arc diff to update the diff.
lshoravi retitled this revision from [BUG 358930] Moving the mouse over a different application icon immediately changes the window list to Framework patch: Moving the mouse over a different application icon immediately changes the window list.Feb 4 2018, 9:17 PM
lshoravi edited the summary of this revision. (Show Details)

Actually it's the opposite: the other patch depends on this one. This is the framework, and that other one uses the changes in this one.

Ah, got it. Updating the titles and reviews, working on the new diffs after that. Just got arcanist set up as well.

Thanks for the help Nathan :)

lshoravi edited the summary of this revision. (Show Details)Feb 4 2018, 9:21 PM
cfeck set the repository for this revision to R242 Plasma Framework (Library).Feb 5 2018, 2:14 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 5 2018, 2:14 AM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
cfeck requested changes to this revision.Feb 5 2018, 2:18 AM
cfeck retitled this revision from Framework patch: Moving the mouse over a different application icon immediately changes the window list to Fix "Moving the mouse over a different application icon immediately changes the window list".
cfeck edited the summary of this revision. (Show Details)
cfeck added a subscriber: cfeck.

Please use the summary to describe what the patch does, not why you added it.

This revision now requires changes to proceed.Feb 5 2018, 2:19 AM
lshoravi edited the summary of this revision. (Show Details)Feb 5 2018, 9:00 AM
lshoravi edited the summary of this revision. (Show Details)Feb 5 2018, 9:02 AM
lshoravi updated this revision to Diff 26573.Feb 5 2018, 12:55 PM
lshoravi edited the summary of this revision. (Show Details)

Updated author as per ngrahams suggestion. Diff updated for latest framework (assuming that it turned out correctly.)

lshoravi updated this revision to Diff 26574.Feb 5 2018, 1:02 PM

And with that said, I specified the wrong revision in arc. This should be the correct diff.

cfeck resigned from this revision.Feb 5 2018, 1:08 PM
mart accepted this revision.Mar 23 2018, 2:50 PM
This revision is now accepted and ready to land.Mar 23 2018, 2:50 PM

FYI Linus doesn't have a developer account, so someone will need to commit this for him.

aacid requested changes to this revision.May 21 2018, 8:59 AM
aacid added a subscriber: aacid.

The code doesn't merge, and after fixing that manually that the code doesn't build because you're doing

dlg->SetAutoShowHide(m_autoShowHide);

and the S is wrong

This revision now requires changes to proceed.May 21 2018, 8:59 AM
Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. · View Herald TranscriptMay 21 2018, 8:59 AM

Please also fill in the testing done field.

src/declarativeimports/core/tooltip.cpp
165

doing a connect inside show() probably isn't what you want, you'll connect multiple times.

Also that signal name has a typo

@lshoravi are you willing and able to address the above-mentioned issues, or should someone else comandeer the revision and do it themselves?

ngraham commandeered this revision.Jan 2 2019, 4:22 AM
ngraham added a reviewer: lshoravi.

I'll finish this.

ngraham updated this revision to Diff 48569.Jan 2 2019, 8:32 PM
ngraham marked an inline comment as done.

Rebase on current master, address review comments, fix bugs

ngraham planned changes to this revision.Jan 2 2019, 8:34 PM

Still doesn't actually work right; need to hack on it more.