Plasma-desktop patch: Moving the mouse over a different application icon immediately changes the window list
Changes PlannedPublic

Authored by ngraham on Feb 4 2018, 7:16 PM.

Details

Reviewers
lshoravi
Group Reviewers
Plasma
Plasma Accessibility
Summary

This patch changes the behaviour of opening applications with multiple windows open in the icons-only task manager. Currently, accidentally mousing over another open application steals focus and closes the thumbnail view. This patch amends that.

BUG: 358930

Depends on D10305

Test Plan
  • Review patches

Diff Detail

Repository
R119 Plasma Desktop
Branch
arcpatch-D10304
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6584
Build 6602: arc lint + arc unit
lshoravi created this revision.Feb 4 2018, 7:16 PM
Restricted Application edited projects, added Plasma; removed Plasma Accessibility. · View Herald TranscriptFeb 4 2018, 7:16 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
lshoravi requested review of this revision.Feb 4 2018, 7:16 PM
lshoravi edited the summary of this revision. (Show Details)Feb 4 2018, 7:19 PM
lshoravi edited the summary of this revision. (Show Details)Feb 4 2018, 7:22 PM
anthonyfieroni added a subscriber: anthonyfieroni.EditedFeb 4 2018, 7:54 PM

You should increase minimal required plasma-framework version to 5.44 but when you do this the patch goes to master i.e. 5.13.

ngraham added a subscriber: ngraham.Feb 4 2018, 8:19 PM

Thanks for doing this! A few notes:

  • Put "BUG: 358930" on its own line in the Summary; this will cause that bug to get closed once this goes in.
  • Put "Depends on D10305" on its own line in the Summary to mark that this patch requires the changes introduced in that other one.
  • No need to mention the bug number in the title (which becomes the commit message).
  • You'll want to mark Réne as the author; to do this, first do git commit --amend --author=" René Fürst <rene@fuerst.biz>" and then arc diff to update the diff.
lshoravi retitled this revision from [BUG 358930] Moving the mouse over a different application icon immediately changes the window list to Plasma-desktop patch: Moving the mouse over a different application icon immediately changes the window list.Feb 4 2018, 9:26 PM
lshoravi edited the summary of this revision. (Show Details)
lshoravi edited the summary of this revision. (Show Details)

Can't seem to get the patches to apply properly. Anyone else that's gotten them to work?

If the other patch applies properly, and is correctly marked as a dependency of this one, I think you can re-base this on master and it will work. But I'm pretty rubbish at dependent patches myself and will let someone else take over,

lshoravi edited the summary of this revision. (Show Details)Feb 5 2018, 9:02 AM
lshoravi added a comment.EditedFeb 5 2018, 9:25 AM

Looking through the diff and master branch, it looks like parts of the functions has changed since René patched it, which seems to cause issues. I'll try to sort it out.

lshoravi updated this revision to Diff 26575.Feb 5 2018, 1:04 PM

New diff and revision. Assuming that the diff was made correctly, this should work.
Correctly set Rene as autho

ngraham commandeered this revision.Jan 2 2019, 4:54 AM
ngraham added a reviewer: lshoravi.

Yoink.

Thank you, Nathan

ngraham updated this revision to Diff 48570.Jan 2 2019, 8:33 PM

Rebase on master, fix bugs

ngraham planned changes to this revision.Jan 2 2019, 8:33 PM

Still doesn't actually work right; need to hack on it more.