Details
Diff Detail
- Repository
- R127 KWayland
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| src/client/protocols/outputdevice.xml | ||
|---|---|---|
| 31–32 | you need to bump this | |
| src/server/outputdevice_interface.cpp | ||
| 520 | You're not actually sending the serial number or eisa anywhere.. The others do it in sendGeometry (including the manufacturer) When you do add it, you need to check the client is bound with version 2, otherwise you'll crash the client. Something like org_kde_output_... | |
| src/server/outputdevice_interface.cpp | ||
|---|---|---|
| 520 | I am sending the stuff in sendGeometry() (see right above) | |
| src/client/protocols/outputdevice.xml | ||
|---|---|---|
| 109–112 | I'm not sure whether it's allowed to add arguments to an existing event. This would result in incompatibilities. You can make the server only emit to clients having the version, but then you actually broke any client which only has version 1. To be really compatible you need to add a new event. | |
In another patch I'm doing a V2 of this interface in the next frameworks cycle.
May as well try to merge this at the same time so we only have 1 version bump?
@dvratil want me to finish this?
@davidedmundson Yes, I'd appreciate it. I won't have time to look into this any time soon, sorry :(
Instead of modifying the geometry event use two new events to remain
fully compatiable.
I just removed handling of dynamically updating eisa/serialNumber it doesn't seem to be something that makes sense for it to change at runtime.
Also I don't want to copy the current setEdid pattern, which is broken ATM. Whenever any new client connects it broadcasts a change to every connected client...
I need to follow that up in another patch, possibly by making it static like these two.