rbreu (Rebecca Breu)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Dec 12 2018, 9:15 PM (40 w, 3 d)
Availability
Available

Recent Activity

Tue, Sep 10

rbreu added a comment to T11485: Steam: Store Page Localization.

OK, I'm done. Let me know if you put it online so I can give it one last read with the propper formatting.

Tue, Sep 10, 6:57 PM · Krita
rbreu added a comment to R37:4fd16ad8cada: BUG 410807: Python Scripter Debugger won't run (Linux) This fixes the issues on….

Should this really go into the 4.2 branch, seeing that it breaks compatibility with Python 2?

Tue, Sep 10, 8:36 AM

Fri, Sep 6

rbreu added a comment to T11485: Steam: Store Page Localization.

Typo in the first sentence: paintaing -> painting

Fri, Sep 6, 11:52 AM · Krita

Mon, Sep 2

rbreu committed R37:1e447588703b: BUG 410807: Python Scripter Debugger won't run (Linux) This fixes the issues on… (authored by rbreu).
BUG 410807: Python Scripter Debugger won't run (Linux) This fixes the issues on…
Mon, Sep 2, 7:04 PM

Aug 9 2019

rbreu committed R37:b1453b9d1935: Python Palette Docker: Exclude from build + Code style fixes (authored by rbreu).
Python Palette Docker: Exclude from build + Code style fixes
Aug 9 2019, 8:33 AM

Mar 30 2019

rbreu added a comment to D20103: Color Slider Docker.

I just tested this and it works. I can see the use of this. What do other people think of this feature? I like how little space the docker takes. Would be neat if the "S" button had a tooltip.

Mar 30 2019, 9:59 PM · Krita

Mar 27 2019

rbreu added a comment to D20023: CMake: Read PYQT_VERSION from PyQt5.QtCore.

Seeing that this would be importing the attributes from where they are documented to be found, and seeing how we've established that this works on several platforms, I'd like to push this anyway.

Mar 27 2019, 7:53 PM · Krita

Mar 24 2019

rbreu requested review of D20023: CMake: Read PYQT_VERSION from PyQt5.QtCore.
Mar 24 2019, 6:48 PM · Krita

Mar 21 2019

rbreu committed R37:cd1927edc4c8: Python code checks: lastdocuments,quick_settings, selectionsbag, tenbrushes… (authored by rbreu).
Python code checks: lastdocuments,quick_settings, selectionsbag, tenbrushes…
Mar 21 2019, 8:27 PM
rbreu closed D19927: Python code checks: lastdocuments,quick_settings, selectionsbag, tenbrushes, tenscripts.
Mar 21 2019, 8:27 PM · Krita

Mar 20 2019

rbreu requested review of D19927: Python code checks: lastdocuments,quick_settings, selectionsbag, tenbrushes, tenscripts.
Mar 20 2019, 8:25 PM · Krita

Mar 12 2019

rbreu committed R37:4edfefc4f441: Python code checks: highpass, script_starter, scriptdocker (authored by rbreu).
Python code checks: highpass, script_starter, scriptdocker
Mar 12 2019, 5:56 PM
rbreu closed D19601: Python code checks: highpass, script_starter, scriptdocker.
Mar 12 2019, 5:56 PM · Krita

Mar 7 2019

rbreu requested review of D19601: Python code checks: highpass, script_starter, scriptdocker.
Mar 7 2019, 7:59 PM · Krita

Feb 21 2019

rbreu added a comment to D19204: Removal of log blend mode.

It doesn't crash! This is a comparison between normal dogde (left) and logarithmi dogd (right). I have no idea if this is correct. Burn is analogous, in that the logarithmic version turns out very black.

Feb 21 2019, 8:24 PM · Krita

Feb 18 2019

rbreu committed R37:1a5da2ab96b1: Python code checks: example_scripts, exportlayers, filtermanager, hello (authored by rbreu).
Python code checks: example_scripts, exportlayers, filtermanager, hello
Feb 18 2019, 7:28 PM
rbreu closed D19089: Python code checks: example_scripts, exportlayers, filtermanager, hello.
Feb 18 2019, 7:28 PM · Krita

Feb 17 2019

rbreu requested review of D19089: Python code checks: example_scripts, exportlayers, filtermanager, hello.
Feb 17 2019, 11:05 AM · Krita

Feb 10 2019

rbreu requested changes to D18668: Add showFloatingMessage to the View Python API.

I'm not sure how strict we are with this stuff in the C++ code, but you introduced a couple of trailing whitespaces:

Feb 10 2019, 10:23 AM · Krita

Feb 9 2019

rbreu committed R37:75dfb78edd83: Python code checks: assigneprofiledialog, colorspace, documentttols (authored by rbreu).
Python code checks: assigneprofiledialog, colorspace, documentttols
Feb 9 2019, 6:10 PM
rbreu closed D18708: Python code checks: assigneprofiledialog, colorspace, documentttols.
Feb 9 2019, 6:10 PM · Krita

Feb 7 2019

rbreu committed R37:d556b73a186d: Adjust Export Layers plugin to new Node.save call (authored by rbreu).
Adjust Export Layers plugin to new Node.save call
Feb 7 2019, 7:23 PM
rbreu closed D18736: Adjust Export Layers plugin to new Node.save call (fixes #403906).
Feb 7 2019, 7:23 PM · Krita

Feb 4 2019

rbreu requested review of D18736: Adjust Export Layers plugin to new Node.save call (fixes #403906).
Feb 4 2019, 9:06 PM · Krita
rbreu added a comment to D18708: Python code checks: assigneprofiledialog, colorspace, documentttols.

I've already added a flake8 config and instructions to run it, and my plan was to squash the flake8 warnings bit by bit and have a bit of an eye on the code, and bring up any issues worth discussing as I find them, such as right now the line lengths (and keep notes for documenting the stuff). From what I've seen so far from the existing plugins and the ones I've written myself, I don't expect much else that's going to be controversial, or an issue with Krita plugins specifically, regarding PEP8.

Feb 4 2019, 5:55 PM · Krita

Feb 3 2019

rbreu requested review of D18708: Python code checks: assigneprofiledialog, colorspace, documentttols.
Feb 3 2019, 6:07 PM · Krita

Jan 27 2019

rbreu closed D18484: Unit Tests for Plugin Importer.
Jan 27 2019, 10:16 AM · Krita
rbreu committed R37:1712da2808e6: Unit Tests for Plugin Importer (authored by rbreu).
Unit Tests for Plugin Importer
Jan 27 2019, 10:16 AM

Jan 25 2019

rbreu updated the diff for D18484: Unit Tests for Plugin Importer.

Added comments.

Jan 25 2019, 2:16 PM · Krita
rbreu closed D18506: Enable automatic docstring genereation in SIP.
Jan 25 2019, 1:41 PM · Krita
rbreu committed R37:e7fe83c9210d: Enable automatic docstring genereation in SIP This will produce basic method… (authored by rbreu).
Enable automatic docstring genereation in SIP This will produce basic method…
Jan 25 2019, 1:40 PM

Jan 24 2019

rbreu requested review of D18506: Enable automatic docstring genereation in SIP.
Jan 24 2019, 7:20 PM · Krita
rbreu added a comment to D18484: Unit Tests for Plugin Importer.

You know, I should probably add some comments.

Jan 24 2019, 5:35 PM · Krita

Jan 23 2019

rbreu requested review of D18484: Unit Tests for Plugin Importer.
Jan 23 2019, 7:08 PM · Krita

Jan 20 2019

rbreu requested review of D18404: Add documentation for Python unit test setup.
Jan 20 2019, 10:25 AM · Krita: Manual

Jan 19 2019

rbreu closed D18305: Python unit test and code check setup.
Jan 19 2019, 12:12 PM · Krita
rbreu committed R37:e9da4ca4090e: Python unit test and code check setup (authored by rbreu).
Python unit test and code check setup
Jan 19 2019, 10:00 AM

Jan 18 2019

rbreu added a comment to D18305: Python unit test and code check setup.

OK, I submitted my developer application.

Jan 18 2019, 9:03 PM · Krita

Jan 16 2019

rbreu added a comment to D18305: Python unit test and code check setup.

Btw, it's also possible to provide an additional version of the mock krita module on github. Since pip can install Python packages from directly from github, that would be an easy way for developers of external plugins to write unit tests.

Jan 16 2019, 9:32 PM · Krita
rbreu requested review of D18305: Python unit test and code check setup.
Jan 16 2019, 9:25 PM · Krita

Jan 15 2019

rbreu updated the diff for D18074: Feature: Python Plugin Importer.

Ooops, I didn't know you need to update a review request with the full patch. Squashed both commits (the original and the typo fix).

Jan 15 2019, 5:32 PM · Krita

Jan 9 2019

rbreu updated the diff for D18074: Feature: Python Plugin Importer.

Fix typo

Jan 9 2019, 6:20 PM · Krita

Jan 7 2019

rbreu requested review of D18074: Feature: Python Plugin Importer.
Jan 7 2019, 9:08 PM · Krita

Jan 4 2019

rbreu added a comment to D17962: Catch SystemExit Exception in Scripter (Fixes #402670).

I don't have push access. I should probably have mentioned that. ;)

Jan 4 2019, 9:16 PM · Krita
rbreu requested review of D17962: Catch SystemExit Exception in Scripter (Fixes #402670).
Jan 4 2019, 2:12 PM · Krita

Dec 19 2018

rbreu requested review of D17701: Remove unneeded sys-imports in Python plugin manuals.
Dec 19 2018, 9:10 PM · Krita: Manual