maciejn (Maciej Niedbalski)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Aug 27 2018, 9:20 AM (51 w, 1 d)
Availability
Available

Recent Activity

Mar 28 2019

maciejn removed a watcher for KDE PIM: Junior Jobs: maciejn.
Mar 28 2019, 11:45 AM
maciejn removed a watcher for Konsole: maciejn.
Mar 28 2019, 11:44 AM

Feb 13 2019

maciejn added inline comments to D17643: Multiple Splits per Tab.
Feb 13 2019, 1:52 PM · Konsole

Jan 28 2019

maciejn added a comment to D17643: Multiple Splits per Tab.

I'm also not too keen on dimming inactive panes. One of the reasons why I suggested giving each pane its own compact header is so the header itself can be the thing that changes color, which will not only avoid impairing readability of the pane itself, but also mimic what happens with the window's own titlebar. It's a familiar concept.

Jan 28 2019, 10:08 PM · Konsole
maciejn requested review of D18587: [WIP ] terminal headers.
Jan 28 2019, 10:05 PM

Jan 25 2019

maciejn added a comment to D17643: Multiple Splits per Tab.
  1. I find it difficult to tell which pane is focused when there are many splits. We should do something to make this clearer. One idea I had was to give each split its own header on top that has the pane's title plus a button on it for activating the context menu without needing to right-click. Then the background of this header could change depending on whether or not its pane has focus. Just a thought. :)
Jan 25 2019, 7:25 AM · Konsole

Jan 24 2019

maciejn added a watcher for Konsole: maciejn.
Jan 24 2019, 8:02 AM

Jan 22 2019

maciejn added a reviewer for D18281: reattach Tab: tcanabrava.
Jan 22 2019, 7:56 PM · Konsole
maciejn updated the diff for D18281: reattach Tab.

unify detach single terminal and detach tab

Jan 22 2019, 7:56 PM · Konsole

Jan 15 2019

maciejn requested review of D18281: reattach Tab.
Jan 15 2019, 9:05 PM · Konsole
maciejn updated the diff for D18259: fix detaching crashes.

rebased

Jan 15 2019, 11:18 AM
maciejn added inline comments to D18259: fix detaching crashes.
Jan 15 2019, 10:18 AM
maciejn added a reviewer for D18259: fix detaching crashes: thsurrel.
Jan 15 2019, 10:15 AM
maciejn added a comment to D18259: fix detaching crashes.

The last patches that got in from Thomas fixes the crash where the closing the detached terminal, can you test without your patches the contents of the original review to see if they also fixes things for you?
One crash that remains is that after you detach, if you close the window of the non-detached-one, things crash.

Jan 15 2019, 10:14 AM
maciejn added a comment to D18250: fix detaching crashes.

Maciej,
I belive you used arc diff comparing with the wrong branch. I can't apply this in my work branch.
Can you update the patch using the right branch to generate the diff?

Jan 15 2019, 9:41 AM · Konsole
maciejn added a reviewer for D18259: fix detaching crashes: tcanabrava.
Jan 15 2019, 9:41 AM
maciejn requested review of D18259: fix detaching crashes.
Jan 15 2019, 9:38 AM

Jan 14 2019

maciejn added a reviewer for D18250: fix detaching crashes: tcanabrava.
Jan 14 2019, 8:09 PM · Konsole
maciejn requested review of D18250: fix detaching crashes.
Jan 14 2019, 8:08 PM · Konsole

Jan 13 2019

maciejn updated the summary of D18231: [WIP] Detach for terminatorStyleTabs.
Jan 13 2019, 7:22 PM · Konsole
maciejn added a reviewer for D18231: [WIP] Detach for terminatorStyleTabs: tcanabrava.
Jan 13 2019, 7:03 PM · Konsole
maciejn requested review of D18231: [WIP] Detach for terminatorStyleTabs.
Jan 13 2019, 7:00 PM · Konsole

Jan 7 2019

maciejn added a comment to D17643: Multiple Splits per Tab.
  • Alternative moving between splits

That's a *really* good improvement over my trial, thanks <3
I'll have some time to play with this patch on mondays and wednsdays for about two hours per day, so I'm back evolving this.

Jan 7 2019, 6:40 PM · Konsole

Jan 5 2019

maciejn updated the diff for D17643: Multiple Splits per Tab.
  • Alternative moving between splits
Jan 5 2019, 3:12 PM · Konsole

Jan 3 2019

maciejn added a comment to D17643: Multiple Splits per Tab.

Hi, we've talked on VDG room about this change a couple of days ago (about maximizing split to be exact). It works exactly as I imagined it. I have two comments:

  • it would be nice to maximize/minimize with the same shortcut

That's easy to do.

  • changing focus for more complicated splits does not work for example 2x2 setup. I've took time and found a way to do this by actual coordinates of splits if you are interested.

it does, with a few grips. If you have a better algorithm than the one I created for the focus handling, I'm all for it. Plese not that this patch will be a bit stale as I don't have time to work on it at the moment.

Just defining 'coordinates' will not work as the problem is that when we try to focus in any direction we need to climb up or down the splitter hierarchy.
Jan 3 2019, 7:16 PM · Konsole

Jan 2 2019

maciejn added a comment to D17643: Multiple Splits per Tab.

Hi, we've talked on VDG room about this change a couple of days ago (about maximizing split to be exact). It works exactly as I imagined it. I have two comments:

  • it would be nice to maximize/minimize with the same shortcut
  • changing focus for more complicated splits does not work for example 2x2 setup. I've took time and found a way to do this by actual coordinates of splits if you are interested.
Jan 2 2019, 9:10 PM · Konsole

Aug 27 2018

maciejn added a watcher for KDE PIM: Junior Jobs: maciejn.
Aug 27 2018, 9:22 AM