In D17643#399933, @ngraham wrote:

I'm also not too keen on dimming inactive panes. One of the reasons why I suggested giving each pane its own compact header is so the header itself can be the thing that changes color, which will not only avoid impairing readability of the pane itself, but also mimic what happens with the window's own titlebar. It's a familiar concept.

In D17643#399423, @ngraham wrote:

2. I find it difficult to tell which pane is focused when there are many splits. We should do something to make this clearer. One idea I had was to give each split its own header on top that has the pane's title plus a button on it for activating the context menu without needing to right-click. Then the background of this header could change depending on whether or not its pane has focus. Just a thought. :)

unify detach single terminal and detach tab

rebased

In D18259#393375, @tcanabrava wrote:

The last patches that got in from Thomas fixes the crash where the closing the detached terminal, can you test without your patches the contents of the original review to see if they also fixes things for you?
One crash that remains is that after you detach, if you close the window of the non-detached-one, things crash.

In D18250#393326, @tcanabrava wrote:

Maciej,
I belive you used arc diff comparing with the wrong branch. I can't apply this in my work branch.
Can you update the patch using the right branch to generate the diff?

In D17643#387673, @tcanabrava wrote:

In D17643#386919, @maciejn wrote:

• Alternative moving between splits

That's a *really* good improvement over my trial, thanks <3
I'll have some time to play with this patch on mondays and wednsdays for about two hours per day, so I'm back evolving this.

• Alternative moving between splits

In D17643#385649, @tcanabrava wrote:

In D17643#385499, @maciejn wrote:

Hi, we've talked on VDG room about this change a couple of days ago (about maximizing split to be exact). It works exactly as I imagined it. I have two comments:

• it would be nice to maximize/minimize with the same shortcut

That's easy to do.

• changing focus for more complicated splits does not work for example 2x2 setup. I've took time and found a way to do this by actual coordinates of splits if you are interested.

it does, with a few grips. If you have a better algorithm than the one I created for the focus handling, I'm all for it. Plese not that this patch will be a bit stale as I don't have time to work on it at the moment.

Just defining 'coordinates' will not work as the problem is that when we try to focus in any direction we need to climb up or down the splitter hierarchy.

Hi, we've talked on VDG room about this change a couple of days ago (about maximizing split to be exact). It works exactly as I imagined it. I have two comments:

• it would be nice to maximize/minimize with the same shortcut
• changing focus for more complicated splits does not work for example 2x2 setup. I've took time and found a way to do this by actual coordinates of splits if you are interested.