- fixes crash when closing with ctrl+d
- fixes crash when closing window tab was detached from
Unit Tests Skipped
The last patches that got in from Thomas fixes the crash where the closing the detached terminal, can you test without your patches the contents of the original review to see if they also fixes things for you?
One crash that remains is that after you detach, if you close the window of the non-detached-one, things crash.
Yes updated diff fixed the crash for me, but because I was appending only one terminal from tab to history in new window you end up with not focusing any terminal after that. This change improves that, so if you close terminal in new window it will focus another one.