fix detaching crashes
ClosedPublic

Authored by maciejn on Jan 14 2019, 8:08 PM.

Details

Reviewers
tcanabrava
Summary

fix detaching crashes

Diff Detail

Repository
R319 Konsole
Branch
arcpatch-D17643_1
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 7098
Build 7116: arc lint + arc unit
maciejn created this revision.Jan 14 2019, 8:08 PM
Restricted Application added a project: Konsole. · View Herald TranscriptJan 14 2019, 8:08 PM
Restricted Application added a subscriber: konsole-devel. · View Herald Transcript
maciejn requested review of this revision.Jan 14 2019, 8:08 PM
maciejn retitled this revision from detach single terminal to fix detaching crashes.Jan 14 2019, 8:09 PM
maciejn edited the summary of this revision. (Show Details)
maciejn added a reviewer: tcanabrava.

Maciej,
I belive you used arc diff comparing with the wrong branch. I can't apply this in my work branch.
Can you update the patch using the right branch to generate the diff?

Maciej,
I belive you used arc diff comparing with the wrong branch. I can't apply this in my work branch.
Can you update the patch using the right branch to generate the diff?

I still cannot predict what arc will do :(. I should stick to web ui for now :D. Try this one https://phabricator.kde.org/D18259

tcanabrava accepted this revision.Jan 16 2019, 8:58 AM
This revision is now accepted and ready to land.Jan 16 2019, 8:58 AM
tcanabrava closed this revision.Jan 16 2019, 8:59 AM

I had to accept to close, sigh.