epopov (Eugene Popov)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Mar 26 2020, 10:06 AM (20 w, 1 d)
Availability
Available

Recent Activity

Jun 1 2020

epopov committed R120:53162d2ab72a: Don't hide clock after idle time on login screen (authored by epopov).
Don't hide clock after idle time on login screen
Jun 1 2020, 1:20 PM

May 19 2020

epopov added a comment to D29818: Check if the clipboard is empty when initializing the status of the Clipboard applet.

Ohhh, okay, thanks anyway😢

May 19 2020, 4:51 PM · Plasma
epopov added a comment to D29818: Check if the clipboard is empty when initializing the status of the Clipboard applet.

Right, but they can be cherry-picked to the Plasma 5.19. In truth, I'm tired of editing these files after every Plasma update☹️

May 19 2020, 4:28 PM · Plasma
epopov added a comment to D29818: Check if the clipboard is empty when initializing the status of the Clipboard applet.

was landed on master, not 5.19

Can it be moved to Plasma 5.19?

May 19 2020, 3:27 PM · Plasma
epopov added a comment to T12842: Improving tab style in Breeze.

What about something like this?

May 19 2020, 1:24 PM · VDG, Breeze
epopov requested review of D29818: Check if the clipboard is empty when initializing the status of the Clipboard applet.
May 19 2020, 9:54 AM · Plasma

May 14 2020

epopov updated the diff for D29652: Automatically close Clipboard applet after clearing history or deleting the last element.

You're right. Fixed.

May 14 2020, 7:17 AM · Plasma

May 11 2020

epopov added a comment to D29652: Automatically close Clipboard applet after clearing history or deleting the last element.

Currently, the Notifications applet closes itself when the last element (notification) is removed (or if all elements are removed by pressing "Clear History" button in the top-right corner). But also it closes itself, even if the applet is pinned, and I guess that this behaviour isn't correct. D29651 fixes this issue.

May 11 2020, 6:12 PM · Plasma
epopov updated the diff for D29651: [applets/notifications] Remain visible after removing all notifications while tray popup is pinned open.

Fixed.

May 11 2020, 5:52 PM · Plasma
epopov added a comment to D29652: Automatically close Clipboard applet after clearing history or deleting the last element.

I believe that there is a better solution, but I did not come up with it.

May 11 2020, 5:45 PM · Plasma
epopov requested review of D29652: Automatically close Clipboard applet after clearing history or deleting the last element.
May 11 2020, 4:13 PM · Plasma
epopov requested review of D29651: [applets/notifications] Remain visible after removing all notifications while tray popup is pinned open.
May 11 2020, 4:10 PM · Plasma

Apr 1 2020

epopov added a comment to D28483: [applets/clipboard] Don't close when clicking history item if pop-up was pinned open by another applet.

Is it normal that I can close pinned applet by pressing ESC?

Apr 1 2020, 7:25 PM · Plasma
epopov added a comment to D28483: [applets/clipboard] Don't close when clicking history item if pop-up was pinned open by another applet.

Thanks!

Apr 1 2020, 4:06 PM · Plasma
epopov updated the diff for D28483: [applets/clipboard] Don't close when clicking history item if pop-up was pinned open by another applet.

Rebase on master

Apr 1 2020, 2:16 PM · Plasma
epopov requested review of D28483: [applets/clipboard] Don't close when clicking history item if pop-up was pinned open by another applet.
Apr 1 2020, 1:52 PM · Plasma
epopov added a comment to D28408: [applets/clipboard]: Fix applet closing itself when clicking on a history item while the tray popup is pinned open.

The previous patch updates the pinned state only for the active applet. For instance, if you open the Networks applet and pin it, then switch to the Clipboard applet and click on the history item, then the Clipboard applet closes. This is because we need to use binding instead of assignment.

Apr 1 2020, 1:44 PM · Plasma
epopov updated the diff for D28408: [applets/clipboard]: Fix applet closing itself when clicking on a history item while the tray popup is pinned open.

Unfortunately, the previous patch doesn't solve the problem completely, but this one should. Can you check it and if everything works well, then replace the previous one with it?

Apr 1 2020, 9:41 AM · Plasma

Mar 31 2020

epopov updated the diff for D28408: [applets/clipboard]: Fix applet closing itself when clicking on a history item while the tray popup is pinned open.

Rebase on master, second edition. Can you try this patch?

Mar 31 2020, 2:35 PM · Plasma
epopov added a comment to D28408: [applets/clipboard]: Fix applet closing itself when clicking on a history item while the tray popup is pinned open.

I have no idea how to test code from master branch

Mar 31 2020, 9:00 AM · Plasma

Mar 30 2020

epopov updated the diff for D28408: [applets/clipboard]: Fix applet closing itself when clicking on a history item while the tray popup is pinned open.

Rebase on master

Mar 30 2020, 7:11 PM · Plasma
epopov added a comment to D28408: [applets/clipboard]: Fix applet closing itself when clicking on a history item while the tray popup is pinned open.

In Plasma/5.18 branch there was a Containment.onAppletAdded handler that took the applet as a parameter, but I can't find this handler in master branch. Unfortunately, I don’t have enough knowledge of Plasma API to know if I can add this handler manually.

Mar 30 2020, 6:22 PM · Plasma
epopov added a comment to D28378: [kcmkwin/kwindesktop] Fix inability to create more than one row on the "Virtual Desktops" settings page.

Well then I have no idea how to fix it

Mar 30 2020, 4:47 PM · KWin
epopov added a comment to D28408: [applets/clipboard]: Fix applet closing itself when clicking on a history item while the tray popup is pinned open.

Can't be rebased on master

Mar 30 2020, 4:43 PM · Plasma
epopov added inline comments to D28354: [applets/digital-clock] Fix calendar events not being shown at first.
Mar 30 2020, 4:16 PM · Plasma
epopov added a comment to D28378: [kcmkwin/kwindesktop] Fix inability to create more than one row on the "Virtual Desktops" settings page.

There's no easy way to do this. I can use something like this:

return Number.fromLocaleString(locale, text.match(new RegExp("[" + locale.groupSeparator + "\\d]+")))

But currently, the number of rows is a positive integer in the range [1..20], so we don't need to take into account the locale when parsing it.

Mar 30 2020, 1:44 PM · KWin
epopov updated the diff for D28354: [applets/digital-clock] Fix calendar events not being shown at first.

Rebase to master

Mar 30 2020, 8:24 AM · Plasma

Mar 29 2020

epopov updated the diff for D28408: [applets/clipboard]: Fix applet closing itself when clicking on a history item while the tray popup is pinned open.

Use hideOnWindowDeactivate property instead of configuration.pin

Mar 29 2020, 11:54 PM · Plasma
epopov added a comment to D28408: [applets/clipboard]: Fix applet closing itself when clicking on a history item while the tray popup is pinned open.

As a question, rather than a researched proposal, is it better to check for the pin in?

systemtray / PlasmoidItem.qml

Connections {
    target: applet
    onExpandedChanged: {

We should be able to hide the pinned applet by clicking in the system tray (at least this can be done now).

Mar 29 2020, 10:35 PM · Plasma
epopov requested review of D28408: [applets/clipboard]: Fix applet closing itself when clicking on a history item while the tray popup is pinned open.
Mar 29 2020, 7:16 PM · Plasma

Mar 28 2020

epopov requested review of D28378: [kcmkwin/kwindesktop] Fix inability to create more than one row on the "Virtual Desktops" settings page.
Mar 28 2020, 4:00 PM · KWin
epopov updated the diff for D28354: [applets/digital-clock] Fix calendar events not being shown at first.

Put the dateEquals function outside the onAgendaUpdated handler, so it can be used elsewhere.

Mar 28 2020, 8:42 AM · Plasma

Mar 27 2020

epopov updated the diff for D28354: [applets/digital-clock] Fix calendar events not being shown at first.

Make a function that compares dates inline.

Mar 27 2020, 6:39 PM · Plasma
epopov requested review of D28354: [applets/digital-clock] Fix calendar events not being shown at first.
Mar 27 2020, 4:46 PM · Plasma
epopov added a comment to D28306: [applets/taskmanager] Make the hover state clarifying, but not main.

Thank you, guys!

Mar 27 2020, 9:36 AM · Plasma

Mar 26 2020

epopov updated the diff for D28306: [applets/taskmanager] Make the hover state clarifying, but not main.

Fix hover state for pinned launchers

Mar 26 2020, 11:13 PM · Plasma
epopov added inline comments to D28306: [applets/taskmanager] Make the hover state clarifying, but not main.
Mar 26 2020, 6:31 PM · Plasma
epopov updated the diff for D28306: [applets/taskmanager] Make the hover state clarifying, but not main.

Use ES6 spread syntax instead of Array.concat()

Mar 26 2020, 6:18 PM · Plasma
epopov updated the diff for D28306: [applets/taskmanager] Make the hover state clarifying, but not main.

Create a new function in TasksTools to make the code more readable.

Mar 26 2020, 4:26 PM · Plasma
epopov requested review of D28306: [applets/taskmanager] Make the hover state clarifying, but not main.
Mar 26 2020, 11:52 AM · Plasma