Differential D28483

[applets/clipboard] Don't close when clicking history item if pop-up was pinned open by another applet
ClosedPublic
Actions

Authored by epopov on Apr 1 2020, 1:52 PM.

Details

Reviewers
ngraham
Commits
R120:247ff0bdb646: [applets/clipboard] Don't close when clicking history item if pop-up was pinned…
Summary

The previous patch updates the pinned state only for the active applet. For instance, if you open the Networks applet and pin it, then switch to the Clipboard applet and click on the history item, then the Clipboard applet closes. This is because we need to use binding instead of assignment.

See https://phabricator.kde.org/D28408.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
epopov created this revision.Apr 1 2020, 1:52 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 1 2020, 1:52 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
epopov requested review of this revision.Apr 1 2020, 1:52 PM
ngraham added a comment.Apr 1 2020, 1:58 PM

This needs to be rebased on master, because, it needs to apply on top of your previous patch, not instead of it.

epopov updated this revision to Diff 79046.Apr 1 2020, 2:16 PM

Rebase on master

ngraham accepted this revision.Apr 1 2020, 3:40 PM

Thanks, I see what you mean now. This is indeed a better solution.

This revision is now accepted and ready to land.Apr 1 2020, 3:40 PM
ngraham retitled this revision from Updated patch that fixes the issue of closing a pinned the Clipboard applet to [applets/clipboard] Don't close when clicking history item if pop-up was pinned open by another applet.Apr 1 2020, 3:40 PM
Closed by commit R120:247ff0bdb646: [applets/clipboard] Don't close when clicking history item if pop-up was pinned… (authored by epopov, committed by ngraham). · Explain WhyApr 1 2020, 3:43 PM
This revision was automatically updated to reflect the committed changes.
epopov added a comment.Apr 1 2020, 7:25 PM

Is it normal that I can close pinned applet by pressing ESC?

ngraham added a comment.Apr 1 2020, 7:50 PM

While it has focus, yes.

Revision Contents
Changeset List

Diff 79061

View Options

applets/systemtray/package/contents/ui/items/PlasmoidItem.qml

Loading...
View Options

applets/systemtray/package/contents/ui/main.qml

Loading...