| ngraham | |
| vkrause |
| Plasma |
I noticed that on the first time I bring up the calendar by clicking the clock on my Plasma panel, it always shows "No event for today". If I click another day on the calendar and then click back on today, it shows today's events fine. It should display it correctly the first time.
To fix this bug, we need to compare the date without time.
BUG: 395956
FIXED-IN: 5.19.0
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
No need to put the function in a separate file; you should put it in CalendarView.qml. Since it's only used once, it could even be inline without defining a new function at all. That's a judgment call though.
If you're gonna have the function live inside the onAgendaUpdated: handler and only be used once, it might as well not be a function at all. :) If you want to keep it a function, it would be good to put it higher up in the file, so it can potentially be used by other things in the future.
Put the dateEquals function outside the onAgendaUpdated handler, so it can be used elsewhere.
| applets/digital-clock/package/contents/ui/CalendarView.qml | ||
|---|---|---|
| 154 | Can't you do date1.getTime() == date2.getTime() (time returns the msecs since epoch) | |
| applets/digital-clock/package/contents/ui/CalendarView.qml | ||
|---|---|---|
| 154 | How can I compare only the date using your expression? | |