Simplified the test

Added const. Removed unnecessery this->

Simplified the code. Overriding operator < instead of using a special class

Fixed style

Fixed a problem: sort(0) -> sort(1)
Fixed style

Fixed issues: m_fileSortedModel -> m_fileSortProxyModel, setDynamicSortFilter(true) instead of connect, VcsFileChangesModel::StateRole return VcsStatusInfo::State, ColumnsRoles -> Column,
rLeft -> source_left, rRight -> source_right, simplified VcsFileChangesSortProxyModel::lessThan, added overide, added = nullptr in constructor deffinition

Style fixes

Fixed style issues

Fixed issues: style, #include <QtWidgets> -> #include <QDialog>

• or -> ||

• Fixed style
• Changed description in dialog
• QRegExp -> QRegularExpression
• \* -> QScopedPointer

• Fixed isssues and moved value.chop() to readConfigOption funtion
• Added unit tests for readConfigOption and setConfigOption

Changed to .ui file from Designer instead of deffineing the ui in c++ source
Style fixed in gitplugin.cpp

@mwolff What do you want my to tests using unit test?
The dialog source (especially after using .ui from Designer) will be very simple. I will only use some abstract functions from other classes. So the potential unit test will in fact be testing the functionality of QRegExpValidator and I don't actually know what else there is to test.
The changes to commit function could be tested (I actually don't know how to test UI interactions, if I don't have the pointer to the QDialog), but again what is there to test? I'm just invoking a getConfigOption, setConfigOption and the QDialog.
What could be tested is the getConfigOption and changes to setConfigOption, but this are also very very simple functions and there isn't any test for the old setConfigOption.

• Small style change
• Fixed the dirty hack in test_filteredproblemstore.cpp

• Workaround for problems wothout correctly set severity
• Changed comments and moved around code

FIXED THE PROBLEM (changed from ProblemStore to FilteredProblemStore in probleemreportermodel.cpp)

• Add debug

• Fixed bug in problemstore.cpp

@kfunk Sorry for the late reaction.

@kfunk please commit

Merged changes with current master. I can't commit becouse I don't have a developer account.

• Removed oktetaglobal.h fully

• Use new-style connect everywhere

• Removed unnecesserry lines from CMakeLists.txt
• Fixed indent in oktetadocument.cpp and new-style connect
• Used dektoptojeson to generate kdevokteta.json
• Cleaned the oktetaglobal.h file
• simplified use of QVariant in oktetaplugin.cpp and removed last KASTEN_VERSION use

Optimized compare. (fixed the issue)

Fixed issues:
"==" -> QString.compare
temporary for reserve and foreach
QLatin1String("") ->{}

• Fixed style

Added remaining manual fixes.

added [-Wclazy-qstring-arg] in this diff because of conflicts

Added manual changes (everything in one diff, because of conflicts)

kfunk, Thank you for all help. I learned a lot while doing this task.

Fixed small mistake in name

Fixed typos and changed from "and" to &&

Removed commented lines. Added more comments.

Don't accelerate near turn.