could you use a .ui file created in designer please? that makes it simpler to maintain UI and change it in the future

QStringLiteral

add spaces around the = please

remove the "get" prefix, just remove it or replace it by "read". these two functions is also what I'd like to see tested. the set of a global option and the getter.

use QRegularExpressionValidator

remove extra spaces

add newlines between functions

remove get prefix, i.e. follow the Qt style. Also remove the Field everywhere.

void setName(const QString& name); // also note the const!
void setEmail(const QString& email); // also note the const!
QString nameField() const;
QString emailField() const;
bool isGlobal() const;

both of these could be put into QScopedPointer or std::unique_ptr. Then remove the delete ... lines from the destructor. I.e. in the .cpp file then write:

GitNameEmailDialog::~GitNameEmailDialog() = default;

rephrase slightly:

You have not yet configured the name and email to be associated with your Git commits.
The values you enter here will be written to the Git configuration, either locally for
the current project only, or globally for all Git projects.

no buttonbox?

please share code, make the QStringList accessible and append --global optionally. No need to copy'n'paste 99% of the code for just that purpose

this may still break on windows, so either use QTextStream and it's readLine, or return a trimmed value. I can't think of a situation where that could break. Whitespaces in config values should not matter afaik.

remove the QDebug, and rewrite this test to make it data-driven, (i.e. use QTest::newColumn, QTest::addRow, QFETCH and a testLocalConfig_data()).

const& the QString args

In Qt-designer it's not possible to add custom name to a button in button box. (or I wasn't able to find a way)

At first I tried to make it data driven, but the initTestCase() and cleanupTestCase() seamed to be interfering with this test. As I don't understand how they are working, I haven't touched them. What I found out is, that repoInit() has to be called at the beginning of the test, because the repo seams to be deleted between tests. If I used data-driven tests the repo would be reinitialized between each test case and that would break my tests.

No global module includes please. Use QDialog and friends

I don't get that regexp. This is accepting everything, right...? Which makes it useless as a validator regex.

Style: Use const QString& name, same below and in other places

Typo: refresh. Better just call that function updateUi

Style: { on same line, same below

It's everything *except* nothing :) So this is an easy validator to ensure the field is not empty.

Oh, indeed. Not an issue then. Thanks.

This test is too complicated for the test coverage it achieves.

This would basically reach the same coverage:

• test reading an option which does not exist, assert value empty
• test setting a option
• test reading back that option, compare values

Kill GitInitTest::runTestLocalConfig, call {set,read}ConfigOption directly in here.