Differential D776

Fixed Clazy warnings in generated code
ClosedPublic
Actions

Authored by apuzio on Jan 10 2016, 6:44 PM.

Details

Reviewers
kfunk
Commits
R51:15d9d9dce8fb: Fixed Clazy warnings in generated code
Summary

Fixed warning: Use midRef() instead [-Wclazy-qstring-ref] in generated code
Fixed warning: QString(const char*) being called [-Wclazy-qstring-uneeded-heap-allocations] in generated code

Test Plan

kdev-php compiles after changes (I have remembered to run make clean before test)

Diff Detail

Repository
R51 KDevelop: PG Qt
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apuzio updated this revision to Diff 1841.Jan 10 2016, 6:44 PM
apuzio retitled this revision from to Fixed Clazy warnings in generated code.
apuzio updated this object.
apuzio edited the test plan for this revision. (Show Details)
apuzio added a reviewer: kfunk.
apuzio set the repository for this revision to R51 KDevelop: PG Qt.
kfunk accepted this revision.Jan 10 2016, 8:04 PM
kfunk edited edge metadata.

LGTM.

Will push.

This revision is now accepted and ready to land.Jan 10 2016, 8:04 PM
Closed by commit R51:15d9d9dce8fb: Fixed Clazy warnings in generated code (authored by kfunk). · Explain WhyJan 10 2016, 8:24 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 1852

View Options

kdev-pg/kdev-pg-code-gen.cpp

Loading...
View Options

kdev-pg/kdev-pg-debug-visitor-gen.cpp

Loading...