Details

Reviewers

mwolff
kfunk

Commits

R52:d620e69d2945: [CLAZY] Fixed most of level 1 and level 2 warnings

Summary

Fixed warnings: QString(const char*) being called [-Wclazy-qstring-uneeded-heap-allocations] with FIXIT fix-fromCharPtrAllocations
Fixed warnings: QString* being called [-Wclazy-qstring-uneeded-heap-allocations] manually (one warnings left inside foreach left, changing to QStringLiteral brakes the build)
Fixed all warnings: Use multi-arg instead [-Wclazy-qstring-arg]
Fixed all warnings (one): Don't call QString::operator[]() on temporary [-Wclazy-detaching-temporary]
Fixed all warnings: Pass small and trivially-copyable type by value (*) [-Wclazy-foreach]
Fixed all warnings: use isEmpty() instead [-Wclazy-isempty-vs-count]
Fixed warnings: Reserve candidate [-Wclazy-reserve-candidates] (one warning left)
Fixed all warnings: warning: Old Style Connect [-Wclazy-old-style-connect]

Left warnings:
warnings: Don't call QList::last() on temporary [-Wclazy-detaching-temporary]
all of warnings [-Wclazy-rule-of-three]
all of warnings: Missing reference on non-trivial type (*) and Pass small and trivially-copyable type by value (*)[-Wclazy-function-args-by-ref]

Diff Detail

Repository

R52 KDevelop: PHP Support

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

apuzio updated this revision to Diff 1837.Jan 10 2016, 5:45 PM

apuzio retitled this revision from to Fixed [-Wclazy-qstring-uneeded-heap-allocations] with FIXIT.

apuzio updated this object.

apuzio edited the test plan for this revision. (Show Details)

apuzio added a reviewer: kfunk.

apuzio set the repository for this revision to R52 KDevelop: PHP Support.

Added manual changes (everything in one diff, because of conflicts)

added [-Wclazy-qstring-arg] in this diff because of conflicts

Added remaining manual fixes.

@mwolff: Please check

pretty good already, some minor things to tweak then +1 from my side.

completion/context.cpp
449	should use .compare(..., Qt::CaseInsensitive) == 0) instead
1526	please rewrite this loop to iterate over a temporary, i.e.: auto files = DUChain::self()->allEnvironmentFiles(url); items.reserve(files.size()); foreach(const auto& env, files) { ...
1769	dito, introduce a temporary please like above
completion/tests/test_completion.cpp
134	the QLatin1String("") should be replaced by a {}
513	here and below: replace by {}, see above

This revision now requires changes to proceed.Jan 10 2016, 11:27 PM

Fixed issues:
"==" -> QString.compare
temporary for reserve and foreach
QLatin1String("") ->{}

one thing, then this is good from my side

completion/context.cpp
33	the `.toLower()` part can now be removed, if you add `, Qt::CaseInsensitive` as second parameter to `.compare()`. Please do that, it's more efficient to do so (saves temporary allocation).

This revision now requires changes to proceed.Jan 12 2016, 10:00 PM

Optimized compare. (fixed the issue)

Just went through the list of changes.

Go for it!

@apuzio: Please rebase + update the patch, it no longer applies.

Push to 5.0 if possible, otherwise just upload the patch (with arc diff please!)

Merged changes with current master. I can't commit becouse I don't have a developer account.

@kfunk please commit

apuzio marked an inline comment as done.Jan 26 2016, 2:35 PM

Closed by commit R52:d620e69d2945: [CLAZY] Fixed most of level 1 and level 2 warnings (authored by apuzio, committed by kfunk). · Explain WhyJan 26 2016, 7:53 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			completion/codemodelitem.cpp (2 lines)
M			completion/context.cpp (50 lines)
M			completion/helpers.cpp (28 lines)
M			completion/implementationitem.cpp (26 lines)
M			completion/includefileitem.cpp (2 lines)
M			completion/item.cpp (2 lines)
M			completion/keyworditem.cpp (14 lines)
M			completion/model.cpp (2 lines)
M			completion/tests/bench_completion.cpp (6 lines)
M			completion/tests/test_completion.cpp (262 lines)
M			docs/phpdocsconfig.cpp (2 lines)
M			docs/phpdocsmodel.cpp (8 lines)
M			docs/phpdocsplugin.cpp (38 lines)
M			docs/phpdocumentationwidget.cpp (8 lines)
M			duchain/builders/declarationbuilder.cpp (16 lines)
M			duchain/builders/typebuilder.cpp (21 lines)
M			duchain/completioncodemodel.cpp (2 lines)
M			duchain/declarations/classdeclaration.cpp (16 lines)
M			duchain/declarations/classmethoddeclaration.cpp (10 lines)
M			duchain/declarations/functiondeclaration.cpp (6 lines)
M			duchain/declarations/namespacealiasdeclaration.cpp (2 lines)
M			duchain/declarations/namespacedeclaration.cpp (2 lines)
M			duchain/expressionevaluationresult.cpp (1 line)
M			duchain/expressionvisitor.cpp (14 lines)
M			duchain/helper.cpp (12 lines)
M			duchain/navigation/declarationnavigationcontext.cpp (26 lines)
M			duchain/navigation/magicconstantnavigationcontext.cpp (18 lines)
M			duchain/tests/benchmarks.cpp (2 lines)
M			duchain/tests/duchain.cpp (94 lines)
M			duchain/tests/duchain_multiplefiles.cpp (36 lines)
M			duchain/tests/duchaintestbase.cpp (2 lines)
M			duchain/tests/uses.cpp (90 lines)
M			duchain/types/integraltypeextended.cpp (2 lines)
M			parser/main.cpp (6 lines)
M			parser/parsesession.cpp (2 lines)
M			parser/php.g (26 lines)
M			parser/test/lexertest.cpp (60 lines)
M			phplanguagesupport.cpp (8 lines)
M			testprovider/phpunitprovider.cpp (4 lines)
M			testprovider/phpunitrunjob.cpp (18 lines)
M			testprovider/testdoxdelegate.cpp (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	1837			Jan 10 2016, 5:41 PM	★	★
Diff 2	1838			Jan 10 2016, 6:01 PM	★	★
Diff 3	1839			Jan 10 2016, 6:12 PM	★	★
Diff 4	1843			Jan 10 2016, 6:48 PM	★	★
Diff 5	1893			Jan 12 2016, 9:36 AM	★	★
Diff 6	1955			Jan 14 2016, 10:26 AM	★	★
Diff 7	1982	15d19b6	Merged changes with current master. I can't commit becouse I don't have a developer account.	Jan 15 2016, 8:30 PM	★	★
Diff 8	2104	93e18aa	rKDEVPHPd620e69d2945a7057776d61c17a3c7e8295efcd4	Jan 26 2016, 7:47 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
f250424cad29	e50ed0ace0d7	15d19b6e6c74 0264c59ec982	Artur Puzio	Merge branch 'clazy_warnings' into clazy_warnings_merge	Jan 15 2016, 8:25 PM
0264c59ec982	3928d557d595	509b61c90467	Artur Puzio	optimized compare	Jan 14 2016, 10:24 AM
509b61c90467	4aca7f19a8d0	dfd962d8853a	Artur Puzio	Fixed issues (QString.compare, temporary for reserve and foreach, {})	Jan 12 2016, 9:34 AM
dfd962d8853a	56536da072b5	3b4771b01a4b	Artur Puzio	Revert "Fixed warning: Don't call QList::last() on temporary [-Wclazy-detaching… (Show More…)	Jan 10 2016, 6:48 PM
3b4771b01a4b	c14e6ec62a95	91048027dbd4	Artur Puzio	Fixed warning: Reserve candidate [-Wclazy-reserve-candidates]	Jan 10 2016, 4:29 PM
91048027dbd4	7673e0ee62b8	e3a45ae8f7d0	Artur Puzio	warning: Old Style Connect [-Wclazy-old-style-connect]	Jan 10 2016, 4:21 PM
e3a45ae8f7d0	ee1fce79da02	979b1b59c74b	Artur Puzio	Fixed warning: warning: Old Style Connect [-Wclazy-old-style-connect]	Jan 10 2016, 3:34 PM
979b1b59c74b	4ad24bf8fbbf	5cca098155e1	Artur Puzio	Fixed warning: Reserve candidate [-Wclazy-reserve-candidates]	Jan 10 2016, 1:16 AM
5cca098155e1	228705aa5d22	ca6882fdbade	Artur Puzio	One QStringLiteral	Jan 10 2016, 1:07 AM
ca6882fdbade	70ac141244b0	9fdd1ebd23f4	Artur Puzio	Changes to php.g	Jan 10 2016, 1:06 AM
9fdd1ebd23f4	de40fb231fee	2a3ae6b87bf9	Artur Puzio	Added manually QStringLiteral	Jan 10 2016, 12:44 AM
2a3ae6b87bf9	68bb30f74360	4d7a0181e592	Artur Puzio	Fixed warning: use isEmpty() instead [-Wclazy-isempty-vs-count]	Jan 10 2016, 12:34 AM
4d7a0181e592	be394fea9e40	c74e5e2f010e	Artur Puzio	warning: Pass small and trivially-copyable type by value (*) [-Wclazy-foreach]	Jan 10 2016, 12:20 AM
c74e5e2f010e	dcfd9c9d1e0d	b42bb97e5f14	Artur Puzio	Fixed warning: Don't call QString::operator[]() on temporary [-Wclazy-detaching… (Show More…)	Jan 10 2016, 12:18 AM
b42bb97e5f14	fbcf78560d3d	f4a6dab9b066	Artur Puzio	Fixed warning: Use multi-arg instead [-Wclazy-qstring-arg]	Jan 10 2016, 12:16 AM
f4a6dab9b066	1926a4b6ff90	8620d2593a54	Artur Puzio	Fixed warning: Don't call QList::last() on temporary [-Wclazy-detaching… (Show More…)	Jan 10 2016, 12:10 AM
8620d2593a54	97bd6df1063e	f3c1d0bdf3ac	Artur Puzio	Fixed warning: QString(const char*) being called [-Wclazy-qstring-uneeded-heap… (Show More…)	Jan 9 2016, 11:17 PM

[CLAZY] Fixed most of level 1 and level 2 warningsClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 2104

completion/codemodelitem.cpp

completion/context.cpp

completion/helpers.cpp

completion/implementationitem.cpp

completion/includefileitem.cpp

completion/item.cpp

completion/keyworditem.cpp

completion/model.cpp

completion/tests/bench_completion.cpp

completion/tests/test_completion.cpp

docs/phpdocsconfig.cpp

docs/phpdocsmodel.cpp

docs/phpdocsplugin.cpp

docs/phpdocumentationwidget.cpp

duchain/builders/declarationbuilder.cpp

duchain/builders/typebuilder.cpp

duchain/completioncodemodel.cpp

duchain/declarations/classdeclaration.cpp

duchain/declarations/classmethoddeclaration.cpp

duchain/declarations/functiondeclaration.cpp

duchain/declarations/namespacealiasdeclaration.cpp

duchain/declarations/namespacedeclaration.cpp

duchain/expressionevaluationresult.cpp

duchain/expressionvisitor.cpp

duchain/helper.cpp

duchain/navigation/declarationnavigationcontext.cpp

duchain/navigation/magicconstantnavigationcontext.cpp

duchain/tests/benchmarks.cpp

duchain/tests/duchain.cpp

duchain/tests/duchain_multiplefiles.cpp

duchain/tests/duchaintestbase.cpp

duchain/tests/uses.cpp

duchain/types/integraltypeextended.cpp

parser/main.cpp

parser/parsesession.cpp

parser/php.g

parser/test/lexertest.cpp

phplanguagesupport.cpp

testprovider/phpunitprovider.cpp

testprovider/phpunitrunjob.cpp

testprovider/testdoxdelegate.cpp

[CLAZY] Fixed most of level 1 and level 2 warnings
ClosedPublic
Actions

Revision Contents
Changeset List