This looks quite expensive.

Try setting http://doc.qt.io/qt-5/qsortfilterproxymodel.html#dynamicSortFilter-prop to true in the proxy model

Use more descriptive name, e.g. m_fileChangesProxyModel

return QVariant::fromValue(m_info.state()).

You will have to Q_DECLARE_METATYPE(VcsStatusInfo::State) in the header

Name enum Column { ... }

Please keep the argument names as in the base class: source_left and source_right. There here to disambiguate between source & proxy model indices.

Simplify: source_left.data(VcsFileChangesModel::StateRole).toInt() should work

Dito, see above.

Style: return a < b

Please add newline at EOF

Use QObject* parent = nullptr (same as baseclass)

Add override

const auto ... (it's a VcsStatusInfo::State, not an int)

Style: (a != b)

Nitpick remove newline.

Ah, and that one was a misunderstanding. I still wanted you to use QString::localeAwareCompare; that was just a style nitpick earlier.

@kfunk: override causes: error "marked override, but does not override"
using suppressed: "warning: virtual bool QStandardItem::operator<(const QStandardItem&) const was hidden"
this-> I will remove.
Unfortunately I haven't received your message probably due to a buggy android IRC client.

Also I see now, I'm should change to bool operator < (const VcsStatusInfoItem & other) const

Still no override. If override does not work, then this means you didn't override the base class method properly => This feature will *not* work as expected.

I have it fixed locally. One question: How did you test that feature? I don't see unversioned files in the commit dialog at all(?)

For git: you see the unversioned files only if you do a git add. I had done it through the right click on file menu. I added such unversioned files, that without sorting the paths are wrong, with sorting paths only an changed file is in between. I can send you a screenshot of the code behaving correctly after the change. If you really want I can add a screenshot before the change.

As for the `bool operator < (const VcsStatusInfoItem &):
I'm NOT overriding the operator actually. The original is bool operator < (const StandardItem&).
The code behaves correctly despite this. If I used bool operator < (const QStandardItem&) I would have to cast the other variable to VcsStatusInfoItem before using it. This would create a potential seg fault if the VcsStatusInfoItem would be compared for some reason to QStandardItem. I understand your concerns about this code not working potentially and I wasn't able to find any information in the QT5 docs.