Feed Advanced Search

Jun 28 2019

strobach added a comment to T11067: Better tiling window manager.

Thanks for evaluating the script again.

I'd like it to have more functional though, but at this point it's more productive to add features there (maybe by creating a fork if needed) rather than rewrite everything from scratch.

We listen to our users. We told you, that the functionality you were requesting is currently impossible to implement.

Jun 28 2019, 12:41 PM · Goal Setting 2019

Jun 14 2019

strobach added a comment to T11067: Better tiling window manager.

@hiangel, thanks for giving us a second chance. This is, however, not a kwin-tiling support forum. Please move the discussion either to our issue tracker, or to the gitter.im chat.

I forgot to add to my prev. comment: I remember there was some opposition to adding some API to kwin, so it wasn't matter of just writing the code. If all of that solved now, then it's nice.

Yes, there was recently a discussion about exposing some API events on Wayland. There were some concerns about breaking Wayland security by doing so. It was, however, decided that the API does not expose any information not available by other means, so the changes got merged about two weeks ago.

My only dissatisfaction so far is with hotkeys: some of them doesn't work OOB

We have very recently decided to remove the non-essential default key bindings, because a) neither of us is an UX specialist, so the bindings were most probably sub-optimal and b) to prevent more future conflicts with Plasma defaults.

although there's "move focused window left/right", but I don't see "focus the left/right window"

It is a design decision to not duplicate KWin's functionality and KWin already has very flexible and polished task switcher. There indeed are "focus next/previous tile" actions, but they have somewhat special meaning in respect to the window "stacking" order and they are unbound by default.

Just to make it clear: is it possible with current API to override kwin hotkeys from the extension? E.g. to allow a user to apply default hotkeys?

I don't know what's the current state, sorry.

I'll probably configure and try to use it on the weekend

Thanks. If you are on Plasma 5.16, please use our master/HEAD. There are some not-yet-released improvements in handling of maximized clients.

Jun 14 2019, 10:33 AM · Goal Setting 2019
strobach added a comment to T11067: Better tiling window manager.

@hiangel, thanks for giving us a second chance. This is, however, not a kwin-tiling support forum. Please move the discussion either to our issue tracker, or to the gitter.im chat.

Jun 14 2019, 9:42 AM · Goal Setting 2019

Jun 13 2019

strobach updated the task description for T11080: KDE for Big Enterprises.
Jun 13 2019, 1:35 PM · Goal Setting 2019
strobach added a comment to T11055: Integrate SMB/NFS Share Mounting.

This is more a subtask of T11080

Jun 13 2019, 1:34 PM · Goal Setting 2019
strobach updated the task description for T11081: Finalize the transition to Wayland and embrace the future of desktop.
Jun 13 2019, 12:37 PM · Goal Setting 2019
strobach added a comment to T11067: Better tiling window manager.

I think there is merit in having a robust tiling experience out of the box no matter how it is implemented, whether baked into kwin or through kwin scripts. Having support in Plasma for it would also mean then exposing it to the user in a discoverable way and documenting it (some users might have never heard of tiling but would like it).

This does not apply exclusively to the KWin tiling functionality. There could be a list of "approved" and supported 3rd-party extensions which would be actively advertised to the user.

Jun 13 2019, 12:21 PM · Goal Setting 2019
strobach added a comment to T11067: Better tiling window manager.

@strobach thanks, I'll give it a try again. I can think of something offhand (e.g. configuring shortcuts), but these would need to be solved when adding a new functionality to kwin anyway.

The script shortcuts in particular are handled and configured in the same way as the rest of global shortcuts. There's almost no difference except for the default binding.

Although, one thing that's definitely better when functional is integrated: you don't need to think about backward compatibility.

Yes, that's a valid argument. Currently it's up to the script maintainer/developer to consciously maintain backwards compatibility.

Jun 13 2019, 12:15 PM · Goal Setting 2019
strobach added a comment to T11067: Better tiling window manager.

Wayland doesn't have concept of managed/unmanaged clients, so if your script checks managed property, you're screwed for the most part. I don't see any other option but introduce a client type enum.

That particular script I'm talking about does not really use managed property.

This would require some adjustments in scripts. :/

Yes, I expect some adjustments to be needed and some run-time X11/Wayland differentiation to be necessary. I'm OK with that - c'est la vie.

Jun 13 2019, 11:17 AM · Goal Setting 2019
strobach added a comment to T11067: Better tiling window manager.
In T11067#188369, @kkharlamov wrote:

@strobach to be clear: last time I tried (2 years ago I think) the kwin tiling script you're referring to has been missing some functionality due to deficiences of API provided by kwin.

Jun 13 2019, 10:54 AM · Goal Setting 2019

Jun 11 2019

strobach updated the task description for T11057: Improve Plasma on touchscreen devices.
Jun 11 2019, 3:55 PM · Goal Setting 2019
strobach added a comment to T11067: Better tiling window manager.

@crozbo, I know that's off-topic here, but still. would you mind to check kwin-tiling script and to open reports against any missing functionality over at our issue tracker?

Jun 11 2019, 12:38 PM · Goal Setting 2019

May 23 2019

strobach added a comment to D17097: [scripting] Emit clientAdded for Wayland clients.

A rogue app could inject malicious code into the script or completely replace it with something else.

Assuming we have an encrypted config section, we can of course store script fingerprint there.

May 23 2019, 1:28 PM · KWin
strobach added a comment to D17097: [scripting] Emit clientAdded for Wayland clients.
  • Add a config option somewhere that enables this functionality (I'm happy editing a file rather than requiring a GUI option)
  • A warning when adding a script that says something about not trusting random scripts from the internet

Neither of the above would solve the issue.

  • The configuration options are stored in plaintext and are writable by any process.
  • The scripting interface is exposed on D-Bus, so any process can download and run any arbitrary script.

The solution would be to store the plugins configuration encrypted (or in general to allow for encrypted config sections) and to remove potentially dangerous methods from the D-Bus interface.

May 23 2019, 1:02 PM · KWin

Mar 26 2019

strobach committed R108:1d4a9d24f867: Expose AbstractClient::setMaximize to scripting (authored by strobach).
Expose AbstractClient::setMaximize to scripting
Mar 26 2019, 8:38 AM
strobach closed D20044: Expose AbstractClient::setMaximize to scripting.
Mar 26 2019, 8:38 AM · KWin

Mar 25 2019

strobach added a comment to D20044: Expose AbstractClient::setMaximize to scripting.

Regardless of the XdgShell protocol, there's currently no way to maximize client from KWin script at all, which is somewhat limiting factor for certain use cases (e.g. Maximized layout in a tiling script such as https://github.com/faho/kwin-tiling).

Mar 25 2019, 6:07 PM · KWin
strobach updated the diff for D20044: Expose AbstractClient::setMaximize to scripting.
  • Use Q_INVOKABLE instead of slot
Mar 25 2019, 4:34 PM · KWin
strobach added a comment to D20044: Expose AbstractClient::setMaximize to scripting.

OK, will do. I did honestly think that this is a bug.

Mar 25 2019, 4:21 PM · KWin
strobach requested review of D20044: Expose AbstractClient::setMaximize to scripting.
Mar 25 2019, 3:54 PM · KWin

Mar 11 2017

strobach committed R122:c6b76da7a679: Add UI for hybrid suspend mode (authored by strobach).
Add UI for hybrid suspend mode
Mar 11 2017, 4:52 PM
strobach closed D5016: Add UI for hybrid suspend mode by committing R122:c6b76da7a679: Add UI for hybrid suspend mode.
Mar 11 2017, 4:52 PM · Plasma
strobach added a comment to D5016: Add UI for hybrid suspend mode.

The question is whether we should treat "hybrid suspend" and "suspend" as separate options or just have a global checkbox "[X] When possible use hybrid suspend".

Mar 11 2017, 4:51 PM · Plasma
strobach added reviewers for D5016: Add UI for hybrid suspend mode: broulik, sebas.
Mar 11 2017, 3:26 PM · Plasma
strobach created D5016: Add UI for hybrid suspend mode.
Mar 11 2017, 3:25 PM · Plasma

Nov 4 2016

strobach added a comment to D3264: [libinput] Load/store device configuration.

Works for me.

Nov 4 2016, 4:03 PM · KWin, Plasma on Wayland
strobach added a comment to D3264: [libinput] Load/store device configuration.

It's funny (is it?) that I'm just doing the same. I should have told you I guess :)
Your solution is simpler anyway. My solution involves inputdevice.kcfg.
I don't think the [vendor][product] key is sufficient. I have two DELL devices here with the same product code, but different name and different functionality. I suggest the key to be [vendor][product][name].

Nov 4 2016, 3:23 PM · KWin, Plasma on Wayland
This is a test notification, sent at Fri, Nov 4, 11:41.
Nov 4 2016, 10:41 AM
This is a test notification, sent at Fri, Nov 4, 11:38.
Nov 4 2016, 10:38 AM
This is a test notification, sent at Fri, Nov 4, 11:36.
Nov 4 2016, 10:36 AM
This is a test notification, sent at Fri, Nov 4, 11:15.
Nov 4 2016, 10:15 AM

Nov 3 2016

strobach closed D3194: Add scroll method selection support.
Nov 3 2016, 1:11 PM · KWin
strobach closed D3193: Add natural scrolling support.
Nov 3 2016, 1:10 PM · KWin
strobach closed D3187: Add support for middle mouse button emulation.
Nov 3 2016, 1:10 PM · KWin
strobach committed R108:e4283543f633: [libinput] Add scroll method configuration support (authored by strobach).
[libinput] Add scroll method configuration support
Nov 3 2016, 1:04 PM
strobach committed R108:b19341777a56: [libinput] Add natural scrolling support (authored by strobach).
[libinput] Add natural scrolling support
Nov 3 2016, 1:04 PM
strobach committed R108:e00649d00224: [libinput] Add middle mouse button emulation support (authored by strobach).
[libinput] Add middle mouse button emulation support
Nov 3 2016, 1:04 PM

Nov 2 2016

strobach updated the diff for D3194: Add scroll method selection support.

Incorporated Martin's suggestion to not translate the Linux button codes.

Nov 2 2016, 5:11 PM · KWin
strobach abandoned D3233: [libinput] Add scroll method support.

Created this one by accident. Sorry for the mess.

Nov 2 2016, 5:09 PM · KWin
strobach added a dependency for D3233: [libinput] Add scroll method support: D3194: Add scroll method selection support.
Nov 2 2016, 5:07 PM · KWin
strobach added a dependent revision for D3194: Add scroll method selection support: D3233: [libinput] Add scroll method support.
Nov 2 2016, 5:07 PM · KWin
strobach retitled D3233: [libinput] Add scroll method support from to [libinput] Add scroll method support.
Nov 2 2016, 5:06 PM · KWin
strobach added inline comments to D3194: Add scroll method selection support.
Nov 2 2016, 4:29 PM · KWin
This is a test notification, sent at Wed, Nov 2, 16:29.
Nov 2 2016, 3:29 PM
This is a test notification, sent at Wed, Nov 2, 16:28.
Nov 2 2016, 3:28 PM
This is a test notification, sent at Wed, Nov 2, 16:27.
Nov 2 2016, 3:27 PM
This is a test notification, sent at Wed, Nov 2, 16:27.
Nov 2 2016, 3:27 PM
strobach added a comment to D3187: Add support for middle mouse button emulation.

Thanks for the explanation.

And that also shows: please push to Plasma/5.8 branch :-)

Do you mean only to Plasma/5.8 and you're going to merge into master later?

yes, I can do the merge. I regularly merge anyway when I push changes)

OK. Thanks again.

Nov 2 2016, 3:26 PM · KWin
strobach added a comment to D3187: Add support for middle mouse button emulation.

Thanks for the explanation.

And that also shows: please push to Plasma/5.8 branch :-)

Do you mean only to Plasma/5.8 and you're going to merge into master later?

Nov 2 2016, 3:22 PM · KWin
strobach added a comment to D3187: Add support for middle mouse button emulation.

Given the number of reviews you have: do you want to apply for a git account? See https://community.kde.org/Infrastructure/Get_a_Developer_Account

I did (https://identity.kde.org/index.php?r=developerApplication/view&id=637).
How to proceed once (if) the application is approved? Since I haven't used Arcanist to create the diff, will it be enough to use "Differential Revision:" keyword in the commit to pair it with the respective diff? Do I understand it right, that there's no mechanism ensuring that what I'm committing is what was under review?

Nov 2 2016, 12:21 PM · KWin

Oct 31 2016

strobach closed D3187: Add support for middle mouse button emulation.

Thanks for the review. Can you please land the diff for me?

Oct 31 2016, 6:38 PM · KWin

Oct 28 2016

strobach updated D3193: Add natural scrolling support.
Oct 28 2016, 11:28 PM · KWin
strobach retitled D3194: Add scroll method selection support from to Add scroll method selection support.
Oct 28 2016, 11:09 PM · KWin
strobach retitled D3193: Add natural scrolling support from to Add natural scrolling support.
Oct 28 2016, 5:22 PM · KWin
strobach retitled D3187: Add support for middle mouse button emulation from to Add support for middle mouse button emulation.
Oct 28 2016, 11:35 AM · KWin
strobach added a member for KWin: strobach.
Oct 28 2016, 11:27 AM