Thanks for the review. Can you please land the diff for me?

Given the number of reviews you have: do you want to apply for a git account? See https://community.kde.org/Infrastructure/Get_a_Developer_Account

Given the number of reviews you have: do you want to apply for a git account? See https://community.kde.org/Infrastructure/Get_a_Developer_Account

I did (https://identity.kde.org/index.php?r=developerApplication/view&id=637).
How to proceed once (if) the application is approved? Since I haven't used Arcanist to create the diff, will it be enough to use "Differential Revision:" keyword in the commit to pair it with the respective diff? Do I understand it right, that there's no mechanism ensuring that what I'm committing is what was under review?

How to proceed once (if) the application is approved? Since I haven't used Arcanist to create the diff, will it be enough to use "Differential Revision:" keyword in the commit to pair it with the respective diff? Do I understand it right, that there's no mechanism ensuring that what I'm committing is what was under review?

Yes it's enough to use the Differential Revision and it will be picked up when pushing. And yes there is no mechanism ensuring that what you are committing is what was under review. KDE puts a great deal of trust in its contributors. As a matter of fact code review is actually non-mandatory. If you look at the commit history you'll see quite a lot commits by me not going through the reviews - especially if I add autotests.

As that change was for a bug report you can auto-close it by using the
BUG: 123456

keyword. And in addition you can specify a:
FIXED-IN: 5.8.4

And that also shows: please push to Plasma/5.8 branch :-)

Thanks for the explanation.

And that also shows: please push to Plasma/5.8 branch :-)

Do you mean only to Plasma/5.8 and you're going to merge into master later?

In D3187#60100, @strobach wrote:

Thanks for the explanation.

And that also shows: please push to Plasma/5.8 branch :-)

Do you mean only to Plasma/5.8 and you're going to merge into master later?

yes, I can do the merge. I regularly merge anyway when I push changes)

In D3187#60101, @graesslin wrote:

In D3187#60100, @strobach wrote:

Thanks for the explanation.

And that also shows: please push to Plasma/5.8 branch :-)

Do you mean only to Plasma/5.8 and you're going to merge into master later?

yes, I can do the merge. I regularly merge anyway when I push changes)

OK. Thanks again.