Add scroll method selection support
ClosedPublic

Authored by strobach on Oct 28 2016, 11:09 PM.

Details

Reviewers
graesslin
Summary

Wraps libinput
libinput_device_config_scroll_get_methods
libinput_device_config_scroll_get_default_method
libinput_device_config_scroll_set_method
libinput_device_config_scroll_get_method
libinput_device_config_scroll_set_button
libinput_device_config_scroll_get_button
libinput_device_config_scroll_get_default_button

the patch is based on the previous two in the series (D3187, D3193).

Diff Detail

Repository
R108 KWin
Branch
libinput_mouse_config
Lint
No Linters Available
Unit
No Unit Test Coverage
strobach updated this revision to Diff 7740.Oct 28 2016, 11:09 PM
strobach retitled this revision from to Add scroll method selection support.
strobach updated this object.
strobach edited the test plan for this revision. (Show Details)
strobach set the repository for this revision to R108 KWin.
Restricted Application added a project: KWin. · View Herald TranscriptOct 28 2016, 11:09 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
graesslin requested changes to this revision.Nov 2 2016, 8:00 AM
graesslin added a reviewer: graesslin.
graesslin added a subscriber: graesslin.
graesslin added inline comments.
libinput/device.cpp
58–118

I'm not sure whether we should do a mapping here. For one as that creates another mapping and we already have one in kwin/pointer_input.cpp

And also I don't think we gain anything from it. We can also make that depend on the actual Linux input button codes. After all the property exposed to dbus is an int. If we use the native linux code we don't need all the mapping and get the same.

This revision now requires changes to proceed.Nov 2 2016, 8:00 AM
strobach added inline comments.Nov 2 2016, 4:29 PM
libinput/device.cpp
58–118

Right. The aliasing, moreover, prevents the user from using some of the buttons. I'll fix it.

strobach updated this revision to Diff 7837.Nov 2 2016, 5:11 PM
strobach edited edge metadata.
strobach updated this object.

Incorporated Martin's suggestion to not translate the Linux button codes.

strobach marked 2 inline comments as done.Nov 2 2016, 5:17 PM
graesslin accepted this revision.Nov 3 2016, 10:44 AM
graesslin edited edge metadata.
This revision is now accepted and ready to land.Nov 3 2016, 10:44 AM
strobach closed this revision.Nov 3 2016, 1:11 PM