Feed Advanced Search

Advanced Search
Use Results
Hide Query

Oct 18 2018

winterz added a comment to D16300: Remove double underscore (__) from header include guards.

fyi, krazy in strict mode will check for leading and trailing underscores on the include guards.
I don't run krazy in strict mode on the EBN, however.

Oct 18 2018, 5:53 PM · Frameworks, Kate

Oct 15 2018

winterz updated the diff for D16195: Clazy: improved explanations.

rebased

Oct 15 2018, 12:21 PM

Oct 14 2018

winterz requested review of D16195: Clazy: improved explanations.
Oct 14 2018, 12:46 PM

Oct 10 2018

winterz added a comment to D16114: Fix keyboard editting of start/end times of VTODOs.
void KTimeComboBox::timeChanged (const QTime & time) [signal]
    Signal if the time has been changed either manually by the user or programatically.
Oct 10 2018, 8:20 PM · KDE PIM
winterz accepted D16114: Fix keyboard editting of start/end times of VTODOs.
Oct 10 2018, 8:12 PM · KDE PIM

Sep 30 2018

winterz requested review of D15854: Clazy: fix --list and --explain command line options.
Sep 30 2018, 12:10 PM

Sep 15 2018

winterz committed R175:3254245838b1: add Ivory Coast holidays (French) Thanks Lukas. seems to work from my limited… (authored by winterz).
add Ivory Coast holidays (French) Thanks Lukas. seems to work from my limited…
Sep 15 2018, 2:29 PM
winterz committed R175:eb1d23a58f90: holiday_hk_* - fix date for Tuen Ng Festival in 2019 BUG: 398670 FIXED-IN: 5.51. (authored by winterz).
holiday_hk_* - fix date for Tuen Ng Festival in 2019 BUG: 398670 FIXED-IN: 5.51.
Sep 15 2018, 2:18 PM

Aug 27 2018

winterz added a comment to D15092: Implement proper equinox and solstice calculation algorithm.

ship it!

Aug 27 2018, 3:20 PM · KDE PIM
winterz accepted D15092: Implement proper equinox and solstice calculation algorithm.

one last question. we are adding a static public method. should we increase the version number?

Aug 27 2018, 2:25 PM · KDE PIM
winterz added a comment to D15092: Implement proper equinox and solstice calculation algorithm.

Yay Dan!
add the @since and we're good to go

Aug 27 2018, 10:58 AM · KDE PIM

Aug 15 2018

winterz added a comment to D14853: Don't fetch missing parts from the resource..

Thank you David.
I can finally save in FatCRM again.

Aug 15 2018, 12:02 PM · KDE PIM

Aug 12 2018

winterz committed R175:7cb3167194b5: src/CMakeLists.txt - install headers the frameworks-way (authored by winterz).
src/CMakeLists.txt - install headers the frameworks-way
Aug 12 2018, 4:17 PM
winterz closed D14754: KHolidays: Install headers according to the frameworks way.
Aug 12 2018, 4:17 PM · KDE PIM
winterz updated the diff for D14754: KHolidays: Install headers according to the frameworks way.

the installed layout looks like this now:

Aug 12 2018, 2:29 PM · KDE PIM
winterz added a comment to D14754: KHolidays: Install headers according to the frameworks way.

I followed the example of KArchive
If KParts is the the better example I will change the patch accordingly.

Aug 12 2018, 12:43 PM · KDE PIM

Aug 11 2018

winterz requested review of D14754: KHolidays: Install headers according to the frameworks way.
Aug 11 2018, 11:15 PM · KDE PIM
winterz committed R79:44fda8c6cfca: src/kaevent.cpp - use CamelCase header for KHolidays (authored by winterz).
src/kaevent.cpp - use CamelCase header for KHolidays
Aug 11 2018, 11:14 PM

Aug 6 2018

winterz added a comment to D14585: avoid crash in MonitorPrivate::emitItemsNotification accessing empty list.

I would appreciate a quick resolution to this crash or at least a temporary commit of Martin's patch.
In the meantime I will commit locally so kontact doesn't crash every time I send an email.

Aug 6 2018, 1:49 PM · KDE PIM

Aug 2 2018

winterz added a comment to D14563: Add CLDR-based country to ISO code mapping.

no objections. looks ok to me.

Aug 2 2018, 7:31 PM · KDE PIM
winterz added inline comments to D14563: Add CLDR-based country to ISO code mapping.
Aug 2 2018, 5:33 PM · KDE PIM

Aug 1 2018

winterz accepted D14537: Install the sunrise/sunset computation header.

absolutely

Aug 1 2018, 4:14 PM · KDE PIM

Jul 31 2018

winterz added a comment to D14524: Fix compiler warning -Wimplicit-fallthrough.

agree that Q_FALLTHROUGH(); is a better idea.
it doesn't duplicate code and it informs the reader that the fallthrough is intentional

Jul 31 2018, 9:07 PM · Frameworks, Kate

Jul 21 2018

winterz committed R175:c3fca749a879: .gitignore - I like to see .diff files so I know if I have patches to apply (authored by winterz).
.gitignore - I like to see .diff files so I know if I have patches to apply
Jul 21 2018, 1:31 PM
winterz committed R175:8c49f9b3dfe2: more Japanese holiday updates from phanect (authored by winterz).
more Japanese holiday updates from phanect
Jul 21 2018, 1:30 PM
winterz closed D14154: re-add updates by Firas Kraiem.
Jul 21 2018, 1:30 PM · KDE PIM

Jul 9 2018

winterz added a comment to D13828: Revert "updated Japanese holidays (in Japanese and English)".

please close this

Jul 9 2018, 11:35 AM · KDE PIM

Jul 8 2018

winterz committed R175:1c2ecfbf9570: holiday_jp_ja, holiday_jp-en_us - updated Thanks for the patch phanect (authored by winterz).
holiday_jp_ja, holiday_jp-en_us - updated Thanks for the patch phanect
Jul 8 2018, 4:08 PM
winterz closed D13812: Revert "updated Japanese holidays (in Japanese and English)".
Jul 8 2018, 4:08 PM · KDE PIM

Jul 2 2018

winterz accepted D13857: Remove dead code.
Jul 2 2018, 7:28 PM · KDE PIM

Jun 6 2018

winterz committed R210:8ec9b5644744: searchdialog_base.ui - add missing tooltip and whatsthis (authored by winterz).
searchdialog_base.ui - add missing tooltip and whatsthis
Jun 6 2018, 12:30 PM

Jun 4 2018

winterz committed R175:a1a34ece1bbb: holidays/plan2/holiday_jp_* - add missing metainfo (authored by winterz).
holidays/plan2/holiday_jp_* - add missing metainfo
Jun 4 2018, 1:22 PM
winterz committed R210:2b752a8ca31b: src/prefs/koprefsdialog.cpp - allow clearing the Holiday region selector (authored by winterz).
src/prefs/koprefsdialog.cpp - allow clearing the Holiday region selector
Jun 4 2018, 12:49 PM

Jun 3 2018

winterz committed R175:49f6abb6035f: updated Japanese holidays (in Japanese and English) BUG: 365241 FIXED-IN: 5.48.0 (authored by winterz).
updated Japanese holidays (in Japanese and English) BUG: 365241 FIXED-IN: 5.48.0
Jun 3 2018, 5:54 PM
winterz committed R175:c7a676924c4d: holidays/plan2/holiday_th_en-gb - updated Thailand (UK English) for 2018 BUG… (authored by winterz).
holidays/plan2/holiday_th_en-gb - updated Thailand (UK English) for 2018 BUG…
Jun 3 2018, 5:30 PM
winterz committed R175:2ef82aef74c0: add Venezula holidays (Spanish) BUG: 334305 FIXED-IN: 5.48.0 (authored by winterz).
add Venezula holidays (Spanish) BUG: 334305 FIXED-IN: 5.48.0
Jun 3 2018, 5:18 PM
winterz committed R210:0f2d4b59cb37: various - now we can configure multiple holiday regions (authored by winterz).
various - now we can configure multiple holiday regions
Jun 3 2018, 4:57 PM
winterz committed R75:cd549ed30928: various - add support for multiple holiday regions (authored by winterz).
various - add support for multiple holiday regions
Jun 3 2018, 4:35 PM
winterz committed R76:f58efa19b9a5: various - support multiple holiday regions (authored by winterz).
various - support multiple holiday regions
Jun 3 2018, 4:15 PM
winterz accepted D13300: PimUniqueApplication: make newInstance virtual..
Jun 3 2018, 12:25 PM · KDE PIM

May 29 2018

winterz committed R210:6bf4b9d54097: Merge branch 'Applications/18.04' (authored by winterz).
Merge branch 'Applications/18.04'
May 29 2018, 5:39 PM
winterz committed R210:7a2df1e6ed39: koviewmanager.cpp - use the fallback when selecting the date for Day View BUG… (authored by winterz).
koviewmanager.cpp - use the fallback when selecting the date for Day View BUG…
May 29 2018, 5:37 PM

May 20 2018

winterz accepted D13002: Fix countryToISO() returning the local country for unknown country names.

I guess this QLocale::bcp47Name() is useless in this situation.

May 20 2018, 3:25 PM · KDE PIM
winterz committed R76:f0ffff73872e: timelabels.cpp - Don't call QList::first() on temporary (found by clazy) (authored by winterz).
timelabels.cpp - Don't call QList::first() on temporary (found by clazy)
May 20 2018, 1:59 PM
winterz committed R76:c49a4b43e3fb: src/agenda/agenda.cpp - const ref range-loop (found by clazy) (authored by winterz).
src/agenda/agenda.cpp - const ref range-loop (found by clazy)
May 20 2018, 1:59 PM

May 19 2018

winterz committed R76:de6b6c8d54d0: todo/todoviewquickaddline - rename returnPressed() slot (for clazy) (authored by winterz).
todo/todoviewquickaddline - rename returnPressed() slot (for clazy)
May 19 2018, 7:49 PM
winterz committed R76:ff98e501db24: src/agenda/calendardecoration.h - de-const some signals (found by clazy) (authored by winterz).
src/agenda/calendardecoration.h - de-const some signals (found by clazy)
May 19 2018, 7:48 PM
winterz committed R76:88d0381697f6: src/agenda/agenda.cpp - Q_EMIT showNewEventPopupSignal (found by clazy) minor… (authored by winterz).
src/agenda/agenda.cpp - Q_EMIT showNewEventPopupSignal (found by clazy) minor…
May 19 2018, 7:32 PM
winterz committed R76:e6c56731183c: src/eventview.h - eventDurationHint is not a SLOT (found by clazy) (authored by winterz).
src/eventview.h - eventDurationHint is not a SLOT (found by clazy)
May 19 2018, 7:32 PM
winterz committed R76:41f996cee34f: src/agenda/agendaview.cpp - removed unused variable found by clazy and some… (authored by winterz).
src/agenda/agendaview.cpp - removed unused variable found by clazy and some…
May 19 2018, 7:32 PM

May 18 2018

winterz committed R75:e632f9aa0ffb: calprinter.h - fix doPrint signature to use fully qualified slot args found by… (authored by winterz).
calprinter.h - fix doPrint signature to use fully qualified slot args found by…
May 18 2018, 10:07 PM
winterz committed R75:74c66cfe3004: src/printing/calprintpluginbase.cpp - restore code removed by accident clazy… (authored by winterz).
src/printing/calprintpluginbase.cpp - restore code removed by accident clazy…
May 18 2018, 10:07 PM
winterz committed R75:e4a09dc36a23: src/calendarutils.cpp - normalize a SLOT/SIGNAL (authored by winterz).
src/calendarutils.cpp - normalize a SLOT/SIGNAL
May 18 2018, 10:07 PM

May 12 2018

winterz committed R210:4ff4e1e932a4: views/collectionview/calendardelegate.cpp - show calendar tooltips (authored by winterz).
views/collectionview/calendardelegate.cpp - show calendar tooltips
May 12 2018, 8:32 PM
winterz committed R75:d6c6d4baf2b9: utils - introduce CalendarSupport::tooltipString() (authored by winterz).
utils - introduce CalendarSupport::tooltipString()
May 12 2018, 7:58 PM
winterz committed R75:f1edbc61db15: autotests/modeltest.cpp - fix signed vs. unsigned comparison warning (authored by winterz).
autotests/modeltest.cpp - fix signed vs. unsigned comparison warning
May 12 2018, 7:58 PM
winterz committed R210:657f1d63fd94: korgac/alarmdialog.h - ENUMS -> ENUM (authored by winterz).
korgac/alarmdialog.h - ENUMS -> ENUM
May 12 2018, 3:38 PM

May 10 2018

winterz added a comment to D10164: Revert "Fix check for cpp macros and usage".

I will change krazy to not complain about GNUC

May 10 2018, 4:18 PM

May 9 2018

winterz committed R210:67c35b410cd3: korgac/alarmdialog.cpp - do a better job finding the incidence to select (authored by winterz).
korgac/alarmdialog.cpp - do a better job finding the incidence to select
May 9 2018, 6:02 PM

May 7 2018

winterz committed R175:e898e6df101f: holiday_es_es - Fix day of the "Comunidad de Madrid" Patch by juanmanuelm (authored by winterz).
holiday_es_es - Fix day of the "Comunidad de Madrid" Patch by juanmanuelm
May 7 2018, 8:15 PM
winterz closed D12711: A holiday must be corrected for Spain.
May 7 2018, 8:15 PM · KDE PIM
winterz committed R237:dba6d83ee412: kcfg.xsd - do not require a kcfgfile element (authored by winterz).
kcfg.xsd - do not require a kcfgfile element
May 7 2018, 5:01 PM
winterz closed D7415: kconfig: kcfg.xsd do not require a kcfgfile.
May 7 2018, 5:01 PM · Frameworks

May 1 2018

winterz committed R165:d5818da2c2e3: collectionrequester.cpp - CollectionRequester::Private::fetchCollection crash… (authored by winterz).
collectionrequester.cpp - CollectionRequester::Private::fetchCollection crash…
May 1 2018, 8:49 PM
winterz closed D12612: Akonadi: CollectionRequester::Private::fetchCollection crash guard.
May 1 2018, 8:49 PM · KDE PIM
winterz updated the diff for D12612: Akonadi: CollectionRequester::Private::fetchCollection crash guard.

I wish I knew how the job could be bad. I can't reproduce.
I guess this doesn't cause any damage but I won't be hurt if you reject this patch. I had a core file so I made a patch

May 1 2018, 12:42 PM · KDE PIM

Apr 30 2018

winterz added a comment to D12612: Akonadi: CollectionRequester::Private::fetchCollection crash guard.

all I know is I had a crash there

Apr 30 2018, 2:59 PM · KDE PIM
winterz requested review of D12612: Akonadi: CollectionRequester::Private::fetchCollection crash guard.
Apr 30 2018, 1:05 PM · KDE PIM

Apr 28 2018

winterz committed R173:532da5c08f4e: various - adjust reference data to try to fix testincidenceformatter again (authored by winterz).
various - adjust reference data to try to fix testincidenceformatter again
Apr 28 2018, 2:53 PM
winterz added a comment to D7415: kconfig: kcfg.xsd do not require a kcfgfile.

ping.
this is still relevant.
some kconfigxt files don't set the kcfgfile element.

Apr 28 2018, 1:55 PM · Frameworks
winterz committed R175:9c8aa21205db: holidays/plan2/holiday_sk_sk - Teacher's Day fix BUG: 393245 FIXED-IN: 5.46 (authored by winterz).
holidays/plan2/holiday_sk_sk - Teacher's Day fix BUG: 393245 FIXED-IN: 5.46
Apr 28 2018, 1:50 PM
winterz abandoned D10255: Prevent infinite recursion in messagelist.

Dan is correct. I'm not sure what I was thinking at the time it was so long ago.

Apr 28 2018, 1:49 PM · KDE PIM

Apr 9 2018

winterz added a comment to D12019: make sure to create unique filename in maildir resource.
In D12019#243301, @mkoller wrote:
Apr 9 2018, 7:34 PM · KDE PIM

Apr 2 2018

winterz committed R175:c84e4d9d1724: holidays/plan2/holiday_in_en-gb - update holiday file for India Thank you for… (authored by winterz).
holidays/plan2/holiday_in_en-gb - update holiday file for India Thank you for…
Apr 2 2018, 5:30 PM
winterz committed R210:1dd12dbbc31f: kodialogmanager.cpp, koviewmanager.cpp - normalize SIGNALs/SLOTs found by clazy (authored by winterz).
kodialogmanager.cpp, koviewmanager.cpp - normalize SIGNALs/SLOTs found by clazy
Apr 2 2018, 1:17 PM

Apr 1 2018

winterz committed R210:955cc026ee72: various - cleanup headers and a bit of coding style (authored by winterz).
various - cleanup headers and a bit of coding style
Apr 1 2018, 4:15 PM

Mar 31 2018

winterz committed R76:c9ad0485bef5: todo/incidencetreemodel.h - minor includes clean (authored by winterz).
todo/incidencetreemodel.h - minor includes clean
Mar 31 2018, 5:30 PM
winterz committed R76:bb9d6efefc50: todo/todoview.cpp - add some KUIT (authored by winterz).
todo/todoview.cpp - add some KUIT
Mar 31 2018, 5:27 PM
winterz committed R76:799bd96536ae: various - tidy-up includes and some coding style (authored by winterz).
various - tidy-up includes and some coding style
Mar 31 2018, 5:27 PM
winterz committed R76:8940e8f36af9: eventview.cpp - fix fallthrough compiler warning (authored by winterz).
eventview.cpp - fix fallthrough compiler warning
Mar 31 2018, 3:19 PM
winterz committed R76:343b00c4a04f: support firstDayOfWeek setting (to override the locale) in monthview CCBUG… (authored by winterz).
support firstDayOfWeek setting (to override the locale) in monthview CCBUG…
Mar 31 2018, 3:12 PM
winterz committed R210:121b91e50368: allow configuring first day of week. BUG: 358106 FIXED-IN: 5.8.0 (authored by winterz).
allow configuring first day of week. BUG: 358106 FIXED-IN: 5.8.0
Mar 31 2018, 3:03 PM

Mar 30 2018

winterz committed R209:f666c9e1033e: kcmkontact.cpp - skip disabled plugins when making the "start with component"… (authored by winterz).
kcmkontact.cpp - skip disabled plugins when making the "start with component"…
Mar 30 2018, 5:38 PM
winterz committed R210:845b5c062286: alarmdialog.cpp - add some missing WhatsThis. minor code style I allow line… (authored by winterz).
alarmdialog.cpp - add some missing WhatsThis. minor code style I allow line…
Mar 30 2018, 4:53 PM
winterz committed R210:9507d8a2a4fc: alarmdialog - add new Suspend menu where you can set/reset default value (authored by winterz).
alarmdialog - add new Suspend menu where you can set/reset default value
Mar 30 2018, 4:31 PM
winterz committed R991:9fe0b2ff2510: pkpasstest.cpp - QCOMPARE fix (compare QString to QString) (authored by winterz).
pkpasstest.cpp - QCOMPARE fix (compare QString to QString)
Mar 30 2018, 12:59 PM

Mar 26 2018

winterz added a comment to D11681: Reworked the German holiday files.

you can push directly.
then close this phab and also close the bugs you opened regarding this problem

Mar 26 2018, 1:58 PM · KDE PIM

Mar 25 2018

winterz accepted D11681: Reworked the German holiday files.

thanks!

Mar 25 2018, 8:51 PM · KDE PIM

Mar 11 2018

winterz committed R252:ddfe408e5848: CMakeLists.txt - not necessary to search for Qt5 Xml (authored by winterz).
CMakeLists.txt - not necessary to search for Qt5 Xml
Mar 11 2018, 5:53 PM
winterz committed R177:4ba6dd6635a3: CMakeLists.txt - remove unnecessary search for Qt5 Network (authored by winterz).
CMakeLists.txt - remove unnecessary search for Qt5 Network
Mar 11 2018, 5:51 PM
winterz committed R178:ef9082512e10: kioslave/src/ldap/CMakeLists.txt - link to Qt5::Network following changes to kio (authored by winterz).
kioslave/src/ldap/CMakeLists.txt - link to Qt5::Network following changes to kio
Mar 11 2018, 5:49 PM
winterz committed R177:885b08046e73: CMakeLists.txt, src/CMakeLists.txt - link to Qt5Network following changes to kio (authored by winterz).
CMakeLists.txt, src/CMakeLists.txt - link to Qt5Network following changes to kio
Mar 11 2018, 5:36 PM
winterz committed R293:10ed1dcc31b6: src/kioslaves/search/CMakeLists.txt - link to Qt5Network following changes to… (authored by winterz).
src/kioslaves/search/CMakeLists.txt - link to Qt5Network following changes to…
Mar 11 2018, 5:15 PM
winterz committed R252:be93ecc1b825: kpackage-install-handlers/kns/CMakeLists.txt - link to Qt::Xml following… (authored by winterz).
kpackage-install-handlers/kns/CMakeLists.txt - link to Qt::Xml following…
Mar 11 2018, 4:57 PM

Feb 26 2018

winterz closed T7193: KCalCore: dump the versit code as Resolved.
Feb 26 2018, 9:27 PM

Feb 25 2018

winterz committed R175:cedceeb3a53a: various - use camelcase headers, minor coding style (authored by winterz).
various - use camelcase headers, minor coding style
Feb 25 2018, 5:33 PM

Feb 24 2018

winterz committed R172:97ce7b6e93c1: various - remove local versit copy and use libical's icalvcal library instead (authored by winterz).
various - remove local versit copy and use libical's icalvcal library instead
Feb 24 2018, 8:03 PM
winterz closed D10799: KCalCore: remove local versit copy and use libical's icalvcal library instead.
Feb 24 2018, 8:03 PM · KDE PIM
winterz updated the diff for D10799: KCalCore: remove local versit copy and use libical's icalvcal library instead.

versit subdir is removed
relocate the includes from vcalformat.h to vcalformat.cpp

Feb 24 2018, 6:13 PM · KDE PIM
winterz added a comment to D10799: KCalCore: remove local versit copy and use libical's icalvcal library instead.
In D10799#212787, @dvratil wrote:

Should the entire versit directory be removed as well?

Feb 24 2018, 5:38 PM · KDE PIM
First
Prev
Next