KHolidays: Install headers according to the frameworks way
ClosedPublic

Authored by winterz on Aug 11 2018, 11:15 PM.

Details

Summary

installs all the headers, including CamelCase headers, into $KDE_PREFIX/include/KF5/KHolidays

Test Plan

all of frameworks still compiles

If any project dependent on KHolidays fails to compile now make sure to use CamelCase headers.

i.e. replace #include <kholidays/foo.h> with #include <KHolidays/Foo>

Diff Detail

Repository
R175 PIM: KHolidays
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
winterz created this revision.Aug 11 2018, 11:15 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptAug 11 2018, 11:15 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
winterz requested review of this revision.Aug 11 2018, 11:15 PM

I'm confused by the removal of PREFIX.

This is a framework that uses a namespace, so it should work like KParts (for instance), which means using PREFIX.

I agree that installing into KHolidays/kholidays/CamelCase was weird and should be removed though ;)

winterz added a comment.EditedAug 12 2018, 12:43 PM

I followed the example of KArchive
If KParts is the the better example I will change the patch accordingly.

Depends whether you want people to #include <Zodiac> (and zodiac.h) (the KArchive solution) or to #include <KHolidays/Zodiac> (and kholidays/zodiac.h) (the KParts solution, i.e. with namespace)

winterz updated this revision to Diff 39523.Aug 12 2018, 2:29 PM
winterz retitled this revision from KHolidays: Instll headers according to the frameworks way to KHolidays: Install headers according to the frameworks way.

the installed layout looks like this now:

$KDE_PREFIX/include/KF5/KHolidays/KHolidays/[CamelCase]
$KDE_PREFIX/include/KF5/KHolidays/kholidays/[non-camelcase.h]

dfaure accepted this revision.Aug 12 2018, 3:13 PM

Much better, thanks ;)

This revision is now accepted and ready to land.Aug 12 2018, 3:13 PM
This revision was automatically updated to reflect the committed changes.