• Merge branch 'htmlinterface' of github.com:eje211/ktorrent into htmlinterface

If I add the same torrent through the UI, it takes seconds, most of the
time, not minutes. There's more: if I add a torrent from the plugin, the
magnet downloader stays at zero peers (unlike with the UI), if I stop and
restart the magnet download, the number of peers goes up but the magnet
still does not download. If I delete the magnet link and add it though the
UI, it downloads find, often in second. Keep in mind that all of this is
called from anther thread. I don't see why it would be a problem but maybe
that's the cause of the issue.

• Merge branch 'htmlinterface' of github.com:eje211/ktorrent into htmlinterface

• Merge branch 'htmlinterface' of github.com:eje211/ktorrent into htmlinterface

• SVN_SILENT made messages (.desktop file) - always resolve ours

• SVN_SILENT made messages (.desktop file) - always resolve ours
• Merge branch '5.1'
• SVN_SILENT made messages (.desktop file) - always resolve ours

Squashed commits.

Squashed commits.

Squashed commits.

True. I'll do it once I've fixed the desktop problem. I can't find what the
base commit was, so I just gave up and I'm just replacing the wrong lines
by hand. I know it's stupid but all the commits I've tried have turned out
to be wrong.

O - Still trying to fix the desktop and notfiyrc issue.

• Still trying to fix the desktop and notfiyrc issue.

Several of the concerns in the previous reviews have been addressed. Most
notably, the Mongoose web server has been replaced by the GNU's libmicrohttpd,
which is available as a shared library.

I didn't know how to update a previous revision. I'll do that instead.

In D11070#222461, @pino wrote:

Not sure why I was added for this review, since I'm not a ktorrent developer...

Anyway, since I'm added, I can provide some general feedback (not on the web part though, as I'm not a web developer):

• please do not add translations to .desktop and .notifyrc files: there is an automated KDE service that handles them from/to PO files
• there is lots of commented code in the added files: please remove it if it is not needed, otherwise it is just clutter
• is the angularjs favicon.ico really needed? if so, please at least use the ktorrent icon (building the .ico file from the .png sources)
• html/source.txt says that the sources are at https://github.com/eje211/ktorrent-web, which makes shipping only the generated files a license issue (since there is no preferred form of modification); also, the files in ktorrent-web have no license specified (big red issue)
• the plugin embeds a copy of the Mongoose library: https://github.com/cesanta/mongoose -- is there no other library for this, that can be used as system library (i.e. without copying it statically in the sources)? ktorrent is not much actively developed, so the big risk here is that the embedded copy would just rot (like already happening with the copy of GeoIP.c); also Mongoose is GPL-2only, which is a long-term licensing issue (since it then forces the license of the resulting work to be GPL-2only)
• what @trufanov and @stikonas already said regarding the usage of a web framework
  
  Also, I posted various reviews of the actual C++ code used.

I'll look into those. You should know that I'm using an existing,
well-known web server library for this, though. But there's always a
possibility of a vulnerability in HOW I use it.