Summary:
AbandonedPublic

Authored by eje211 on Mar 17 2018, 8:35 AM.

Details

Summary

Several of the concerns in the previous reviews have been addressed. Most
notably, the Mongoose web server has been replaced by the GNU's libmicrohttpd,
which is available as a shared library.

There is also a basic security feature which can be improved later: any
message that makes a change in KTorrent requires a verificacion key. One thing
that could make this system safer could be to randomize that key from time
to time.

One problem I could not crack is that adding a mangnet link does not work as
expected. The code that adds magnet links is the same as the callback from
the code that adds magnet links from the callback menus, but when my plugin
tries to add a magnet link, they just appear in the "Magnet Downloads" panel
and they there with zero peers. I have no idea why.

Diff Detail

Branch
htmlinterface
Lint
No Linters Available
Unit
No Unit Test Coverage
eje211 requested review of this revision.Mar 17 2018, 8:35 AM
eje211 created this revision.
eje211 set the repository for this revision to R473 KTorrent.
pino requested changes to this revision.Mar 17 2018, 9:14 AM

Please reuse D11070: An alternative to the web interface by editing it, instead of creating a new revision...
Also:

  • please create a cmake module that looks for microhttpd, and enable the build of the plugin only if found
  • please address the concerns I expressed when reviewing D11070: An alternative to the web interface regarding memory leaks, exposure/visibility of private/internal functions in headers, commented code, etc
This revision now requires changes to proceed.Mar 17 2018, 9:14 AM
eje211 abandoned this revision.Mar 17 2018, 3:59 PM

I didn't know how to update a previous revision. I'll do that instead.