Tested for "up to 5", works wonderful so far, I will test the rest tomorrow.
We are missing an objectif, I put it in the code as comment.

Code change is good for me. Test shows that it is working properly. Ok button has been well implemented and mulipledataset well added. Great job.
We need just to add an additional feature compare to the initial project.
You need to add multiple question for each sublevel.
At the moment there is only one answer to give to validate a sublevel. We need at least 5 questions per sublevel and the number of questions for each sublevel must be configurable in the qml file.
You need for that to be able to generate randomize questions according to numberOfItemMax.

Could you update the description and the qml objective?
1- From
count or recognize the items up to 4 of 1 type.
to
Group 4 types of fruits and enumarate each group (4 fruits max)
and this adapted for each objective?

Can you add an ok button.
Can you display the sub objectif for each level?
Otherwise so far it is good for me.

Hi,
Could you implement MultipleDataset4 and MultipleDataset5?
Emmanuel

Hi,
I read the code and tested it manually, I can not see any problems.
Could you add the following :

• Ok button to valid the answer, we will need it to be able to catch and be able to analyse errors when we will have the server,
• Objective message which is missing,
• find and correct following error messages:

qrc:/gcompris/src/activities/scalesboard/Scalesboard.qml:244: TypeError: Value is undefined and could not be converted to an object
qrc:/gcompris/src/activities/scalesboard/Scalesboard.qml:248: TypeError: Value is undefined and could not be converted to an object
qrc:/gcompris/src/activities/scalesboard/Scalesboard.qml:198: TypeError: Value is undefined and could not be converted to an object
To reproduce the error, click on config button choose a different option then save.

Hi,
I tested it looked at the code and this is for me ready to be merged. Well done!
Emmanuel

see my comment about comment :)

commented on maxsublevel which is not self explanable variable name.

Please build the mecanism which creates the data to be given to the user, it will solve most of our problems. Good luck :)

On my side I do not see anything to correct so far. I think next test will be done by real pupils :) Great work!

See new comments about data choice algorithme.

Sorry forgot to submit my comments yesterday. Here are then my comments.

Sure, please do it, it will be much better.

Can you update the task description using the format we are using in the main mutitpledtataset tasks description?

When you are asking full hour question in level time containing minuts you need to have the display options for minuts too.
You are targeting the dataset to pupils that must be able to handle these additional informations.
This is true for all levels.

Can you modify the options messages to make them shorter. I commented two of them in the code.

Something is not logic when I select multipledatasets. Let says I select

• full
• full and half
• full half and quarter of an hour

I should have six levels, two from each, I have 6 levels:

• 4 fulls
• 1 full and half
• 1 full half and quarter of an hour

Could you have a look to this?
Thanks

Hi Deepak,
We will need an supplementary option there not sure how to handle it.
https://en.wikipedia.org/wiki/Date_and_time_representation_by_country
Most countries use 24 hours clock even thought on the clock we only see 0 to 12 on the display.
But english speaking region are using AM PM, we will need to support both.
We could use an option button like we have in gletters to choose between 24 and 12 hours option, or offer for each dataset both format:

• full hours (24 hours format)
• full hours (12 hours format)

Please use a hard copy of the data you want to modify to solve the problems you have. Be careful to not break gletters.

I added a sublevel 1 in multidataset1 and modified the number of stars for multidataset2. I also added that from quantity 6 the nb of stars is 3.

Deepak,
Could you please update de task description following the format you used in your porposal.
Thanks

I will see with Johnny.

Level 2 and 3 do not have any ok button. We will need them to be able to asses the pupils answers.

Could you do a sum up list of the changes you have done so that I can check them without forgetting anything?
Thanks.

I do not understand why we have a tutorial about leap year in this activity.

git apply D26252.diff
error: patch failed: src/activities/calendar/Calendar.qml:459
error: src/activities/calendar/Calendar.qml: patch does not apply
error: src/activities/find_the_day/resource/1/Data.qml: No such file or directory

I have several problems.

• I can not see the numerical suite.
• When I choose "guess a number between 1 and 100" and "guess a number between 1 and 20", if I save it then go back to the settings, unselect "guess a number between 1 and 100", I still have the levels up to 100.

I think the possibility to have non exclusif choice in multipledataset config menu will cause problems in smallnumbers where we want to follow a precise plan to teach/train numbers.

Tested and I find some pedagogical problems. Lets take the level to learn 9.
We train first 9 in level 1 then we forget about it until level 6.
I would propose the following:

This would be great. We have to be be careful, I just had a look to the activity and there are mistake for capital A M N O Q T X Y!
So if we do this we should follow a guide. The most efficient one for cursive is the following one
http://lutinbazar.fr/wp-content/uploads/2015/04/r%C3%A9glette-graphisme_avec-indications-de-trac%C3%A9s-LB.pdf

Tested this morning, this is totally functionnal for both redraw and redraw_symmertrical.

I updated the Description, adding multipledata1 for preschool kids and some description of each level for each multipledataset.

Hi,
Can we add an additional level? This is a very interesting activity for 5 years old.
I would add

Hi,
Excellent work!
Just a point, in config display the menu are not exclusive, I can select option 1 and option 2. It could be good when I select option 2 that option 1 would be disabled.
Also I have an error message that was I think not there before
qrc:/gcompris/src/activities/guessnumber/AnswerArea.qml:69: TypeError: Cannot read property 'maxNumber' of undefined
Could you have a look please?
Also, let choose
MultipleData4: Recommended age: 9-10
max number 1 000 000.
Could you try to find a way to group numbers when you diplay them by three.
Exemple: 250 000 instead of 250000 which is too difficult to read even for an adult.
Emmanuel

Hi,
Let choose
MultipleData4: Recommended age: 9-10
max number 1 000 000.
Could you try to find a way to group numbers when you diplay them by three.
Exemple: 250 000 instead of 250000 which is too difficult to read even for an adult.
Emmanuel

Hi,
Excellent work!
Just a point, in config display the menu are not exclusive, I can select option 1 and option 2. It could be good when I select option 2 that option 1 would be disabled.
Also I have an error message that was I think not there before
qrc:/gcompris/src/activities/guessnumber/AnswerArea.qml:69: TypeError: Cannot read property 'maxNumber' of undefined
Could you have a look please?
Emmanuel

Moved to WIP

I claim this task.

Hi,
Yes, as long as they are not sok activity.
Regards,

Hi,
This task is part of sok2020. You can not claim it.
https://phabricator.kde.org/T12341
There are still lots of other activities where you can add multipledatasets.
Regards,

Go for it! Don't forget to put it in work in progress.