Feed Advanced Search

Sep 9 2022

bam added a comment to D26719: [Battery Monitor] Glow icon on hover.

Nice. Could the same technique be applied for keyboardlayout applet?
Currently, it glows a bit on hover when showing a flag icon only. No such effect when in text label mode.

Sep 9 2022, 10:23 AM · Plasma

May 17 2021

bam added a comment to T13722: Flags (not the int type) from kdelibs4support.

Actually, a Text/Label element would be better for showing emojis at small sizes because it supports subpixel antialiasing.

Even so, seems old hand-made PNGs drawn on pixel-by-pixel basis give the best result at smallest size, so I doubt we need to smash it to something else. Rather than adding on top, maybe.

May 17 2021, 1:12 PM · VDG, KF6
bam added a comment to T13722: Flags (not the int type) from kdelibs4support.

Relevant setting, true by default:
https://doc.qt.io/qt-5/qml-qtquick-image.html#smooth-prop
I wonder if it makes any impact when scaling up in several sizes, 2x or more..

May 17 2021, 1:06 PM · VDG, KF6

May 14 2021

bam added a comment to T13722: Flags (not the int type) from kdelibs4support.

Thanks for the in-depth description and clarification.

The solution to the blurriness problem would be to make pixel aligned flags for every icon size we might use.

I asked upstream to see what reaction would be for providing smaller variants of the icons:
https://github.com/hfg-gmuend/openmoji/issues/317

May 14 2021, 10:35 PM · VDG, KF6
bam added a comment to T13722: Flags (not the int type) from kdelibs4support.

The solution to the blurriness problem would be to make pixel aligned flags for every icon size we might use.

Do you mean in raster?

May 14 2021, 2:16 PM · VDG, KF6
bam added a comment to T13722: Flags (not the int type) from kdelibs4support.

That's just what happens when you don't make images for the exact size you will be using them at

So what should be the solution? I thought strong point of SVG is it doesn't tied to any particular size.

May 14 2021, 9:35 AM · VDG, KF6

May 13 2021

bam added a comment to T13722: Flags (not the int type) from kdelibs4support.

@driglu4it we also have problem with blurring SVG icons on small sizes, could you also provide the screenshots?

May 13 2021, 7:02 PM · VDG, KF6

Jan 13 2021

bam added a comment to T13722: Flags (not the int type) from kdelibs4support.

I think it would be cool if we just started with anything.
Just need to watch new icons looks not worse in small scale than kdelibs4suppors's ones.

Jan 13 2021, 3:12 PM · VDG, KF6

Jan 10 2021

bam added a comment to T13722: Flags (not the int type) from kdelibs4support.

Yes, I was saying that Twemoji was more detailed and correct than OpenMoji.

The idea was having more details is not necessary good for this particular case. I thought having flags somewhat abstracted is what we need here, and only OpenMoji suits that idea what I can see.
Maybe I'm wrong, need to see it in actual scale in comparison.

Jan 10 2021, 5:19 PM · VDG, KF6
bam added a comment to T13722: Flags (not the int type) from kdelibs4support.

It seems to me Twemoji still has much more details for that flag.
Anyway, could we have more than one flag vendors available?
Ideally, they should be just auto-generated from that vendors, shall the modifications needed at all.

Jan 10 2021, 3:28 PM · VDG, KF6

Jan 8 2021

bam added a comment to T13722: Flags (not the int type) from kdelibs4support.
In T13722#247618, @bam wrote:

What do you think about Openmoji? Sharp corners but thick black outline. Still might look good, IMO.

That outline is just a separate SVG element (<g id="line">), should be easy to remove automatically.

Jan 8 2021, 5:39 PM · VDG, KF6

Jan 5 2021

bam added a comment to T13722: Flags (not the int type) from kdelibs4support.

Marble has full-fledged flags from Widipedia, they are not suit well our needs: https://invent.kde.org/education/marble/-/tree/master/data/flags
The only abstracted variant I faced is OpenMoji, for comparison: https://emojipedia.org/flag-afghanistan/

Jan 5 2021, 7:14 PM · VDG, KF6
bam added a comment to T13722: Flags (not the int type) from kdelibs4support.

Thanks Noah. Yes that support burden frightens me also (not sure how often they are updating, though).
What do you think about Openmoji? Sharp corners but thick black outline. Still might look good, IMO.
And about the corners, maybe round corners are not that bad?
Or just create several flag themes, one for each emoji vendor?
Too many questions, I know.

Jan 5 2021, 5:35 PM · VDG, KF6

Jan 4 2021

bam updated subscribers of T13722: Flags (not the int type) from kdelibs4support.

Advantage of "real" icon is that it supports overlay text on top (IconItem), and can be highlighted in a standard way (with Active mode).
So it's still a reasonable alternative over emoji I think.
@mart

Jan 4 2021, 3:43 PM · VDG, KF6

Dec 22 2020

bam added inline comments to D25586: KCM WorkspaceOptions port to KConfigXT. Take into account immutable properties.
Dec 22 2020, 9:55 PM · Plasma

Dec 20 2020

bam added inline comments to D25586: KCM WorkspaceOptions port to KConfigXT. Take into account immutable properties.
Dec 20 2020, 4:32 PM · Plasma

Dec 18 2020

bam added a comment to D4220: Add a basic SNI for keyboard layout.

Not a revert but rather rollback of SNI part:
https://invent.kde.org/plasma/kwin/-/merge_requests/560

Dec 18 2020, 8:09 PM · KWin, Plasma on Wayland
bam added a comment to D4220: Add a basic SNI for keyboard layout.

We are going to revert this in favor of https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/181:
it supports all the existing functional here plus missing one (problem with short layout names was solved):

  • flags and/or short text for the layouts

If any objections, please tell.

Dec 18 2020, 12:35 PM · KWin, Plasma on Wayland

Dec 10 2020

bam added inline comments to D4135: Split implementation of keyboard layout handling into a dedicated class.
Dec 10 2020, 9:33 PM · KWin, Plasma on Wayland
bam added inline comments to D4135: Split implementation of keyboard layout handling into a dedicated class.
Dec 10 2020, 8:25 PM · KWin, Plasma on Wayland

Nov 9 2020

bam added a comment to D6628: Fix and normalize license in .desktop files.

Thanks for clarifying.

In D6628#676721, @mak wrote:

So, this change looks fine to me now, as it is :-)

And yet it was changed again! :-D
https://github.com/KDE/plasma-desktop/commit/05c230733a1b9d16c0e52eb54955c62d340b94e3

Nov 9 2020, 1:19 PM · Plasma
bam added a comment to D6628: Fix and normalize license in .desktop files.

Starting version 2.0, it is no longer valid to use the + operator in a license identifier

should we address it?
https://en.wikipedia.org/wiki/Software_Package_Data_Exchange#Deprecated_syntax

Nov 9 2020, 10:48 AM · Plasma

Nov 5 2020

bam added a comment to D22846: Port KeyboardLayout component to use generated DBus interface.

I wonder if we could "share" that .xml between server and client somehow..

Nov 5 2020, 8:51 PM · Plasma

Nov 4 2020

bam added a comment to D22846: Port KeyboardLayout component to use generated DBus interface.

Does it mean we now have to manually synchronize DBus API here in .xml and on KWin side?

Nov 4 2020, 2:56 PM · Plasma

Oct 27 2020

bam created T13816: Test unmerged patches.
Oct 27 2020, 11:12 PM · build.kde.org

Oct 7 2020

bam added a comment to T13722: Flags (not the int type) from kdelibs4support.

...
non-waving flags: https://emojipedia.org/twitter/

Oct 7 2020, 4:21 PM · VDG, KF6

Oct 5 2020

bam added a comment to T13722: Flags (not the int type) from kdelibs4support.

Thanks for input everyone.
About option 2, if someone knows emoji font resemble these: https://lxr.kde.org/source/frameworks/kdelibs4support/src/l10n/ (the flags are inside 2-letter dirs, installing to kf5/locale/countries/%1/flag.png), please let us know. I think non-waving version is preferable.

Oct 5 2020, 3:01 PM · VDG, KF6

May 13 2020

bam added a comment to R260:b883cb894c11: Undo custom support for ccache.

Is it documented anywhere how one can build Plasma with -DCMAKE_CXX_COMPILER_LAUNCHER=ccache?

May 13 2020, 11:12 AM

May 7 2020

bam added a comment to T11640: sddm without X.

BTW, GDM seems already run so :)

May 7 2020, 6:50 PM · Plasma on Wayland

Apr 27 2020

bam added a member for KDE Yocto: bam.
Apr 27 2020, 11:04 PM
bam added a watcher for KDE Yocto: bam.
Apr 27 2020, 12:52 AM

Nov 13 2019

bam removed a watcher for Discover Software Store: bam.
Nov 13 2019, 4:42 PM

Oct 1 2019

bam added a comment to D24285: fix: 'lmdb' not found.

This seem had already been fixed : https://phabricator.kde.org/R256:03011c6e3c689c3e13c91e964000fd66fbb80daf

Oct 1 2019, 2:00 PM · Discover Software Store

Sep 28 2019

bam added a reviewer for D24286: fix ostree build: apol.
Sep 28 2019, 7:06 PM · Discover Software Store
bam added a reviewer for D24288: don't build gobject-introspection: apol.
Sep 28 2019, 7:05 PM · Discover Software Store
bam updated subscribers of D24288: don't build gobject-introspection.
Sep 28 2019, 7:05 PM · Discover Software Store
bam updated subscribers of D24286: fix ostree build.
Sep 28 2019, 7:05 PM · Discover Software Store
bam added a reviewer for D24285: fix: 'lmdb' not found: apol.
Sep 28 2019, 7:00 PM · Discover Software Store
bam added a project to D24288: don't build gobject-introspection: Discover Software Store.
Sep 28 2019, 6:59 PM · Discover Software Store
bam added a project to D24285: fix: 'lmdb' not found: Discover Software Store.
Sep 28 2019, 6:58 PM · Discover Software Store
bam added a project to D24286: fix ostree build: Discover Software Store.
Sep 28 2019, 6:58 PM · Discover Software Store
bam added a dependency for D24288: don't build gobject-introspection: D24286: fix ostree build.
Sep 28 2019, 6:56 PM · Discover Software Store
bam added a dependent revision for D24286: fix ostree build: D24288: don't build gobject-introspection.
Sep 28 2019, 6:56 PM · Discover Software Store
bam requested review of D24288: don't build gobject-introspection.
Sep 28 2019, 6:56 PM · Discover Software Store
bam added a dependent revision for D24285: fix: 'lmdb' not found: D24286: fix ostree build.
Sep 28 2019, 6:55 PM · Discover Software Store
bam added a dependency for D24286: fix ostree build: D24285: fix: 'lmdb' not found.
Sep 28 2019, 6:55 PM · Discover Software Store
bam requested review of D24286: fix ostree build.
Sep 28 2019, 6:41 PM · Discover Software Store
bam requested review of D24285: fix: 'lmdb' not found.
Sep 28 2019, 6:39 PM · Discover Software Store

Jan 14 2019

bam updated the diff for D17767: add access to system Flatpak installations.

(redudant) rebase

Jan 14 2019, 7:36 PM · Discover Software Store

Dec 24 2018

bam updated the diff for D17767: add access to system Flatpak installations.

rebase

Dec 24 2018, 12:22 PM · Discover Software Store
bam updated the diff for D17671: reflect dependencies.

rebase

Dec 24 2018, 12:22 PM · Discover Software Store
bam updated the diff for D17670: remove extra modules.

rebase

Dec 24 2018, 12:22 PM · Discover Software Store
bam updated the diff for D17669: use more appropriate git branches.

rebase

Dec 24 2018, 12:22 PM · Discover Software Store
bam updated the diff for D17668: remove unneeded filesystem shares.

rebase

Dec 24 2018, 12:22 PM · Discover Software Store
bam updated the diff for D17667: remove unknown option.

rebase

Dec 24 2018, 12:22 PM · Discover Software Store
bam updated the diff for D17666: disable unneeded module properly.

rebase

Dec 24 2018, 12:19 PM · Discover Software Store
bam updated the diff for D17662: remove wrapper script.

rebase

Dec 24 2018, 12:15 PM · Discover Software Store
bam updated the diff for D17671: reflect dependencies.

move snapd-glib also

Dec 24 2018, 11:04 AM · Discover Software Store

Dec 23 2018

bam added a project to D17767: add access to system Flatpak installations: Discover Software Store.
Dec 23 2018, 10:42 PM · Discover Software Store
bam updated the diff for D17666: disable unneeded module properly.

rebase

Dec 23 2018, 10:33 PM · Discover Software Store
bam updated the diff for D17662: remove wrapper script.

minor corrections

Dec 23 2018, 10:25 PM · Discover Software Store
bam added a dependent revision for D17671: reflect dependencies: D17767: add access to system Flatpak installations.
Dec 23 2018, 10:16 PM · Discover Software Store
bam added a dependency for D17767: add access to system Flatpak installations: D17671: reflect dependencies.
Dec 23 2018, 10:16 PM · Discover Software Store
bam requested review of D17767: add access to system Flatpak installations.
Dec 23 2018, 10:15 PM · Discover Software Store
bam abandoned D17723: run wrapper from within .desktop.

Not needed any more

Dec 23 2018, 10:04 PM · Discover Software Store
bam updated the diff for D17668: remove unneeded filesystem shares.

rebase

Dec 23 2018, 9:53 PM · Discover Software Store
bam updated the diff for D17666: disable unneeded module properly.

rebase

Dec 23 2018, 9:39 PM · Discover Software Store
bam updated the diff for D17662: remove wrapper script.

remove wrapper script

Dec 23 2018, 9:07 PM · Discover Software Store

Dec 22 2018

bam added a comment to D17723: run wrapper from within .desktop.

@apol I don't have development account, so probably I can't.
I would be gratitude if you land it then. Thanks

Dec 22 2018, 1:23 AM · Discover Software Store

Dec 21 2018

bam updated the summary of D17723: run wrapper from within .desktop.
Dec 21 2018, 5:11 PM · Discover Software Store
bam added a dependency for D17723: run wrapper from within .desktop: D17671: reflect dependencies.
Dec 21 2018, 5:00 PM · Discover Software Store
bam added a dependent revision for D17671: reflect dependencies: D17723: run wrapper from within .desktop.
Dec 21 2018, 5:00 PM · Discover Software Store
bam added a project to D17723: run wrapper from within .desktop: Discover Software Store.
Dec 21 2018, 4:59 PM · Discover Software Store
bam requested review of D17723: run wrapper from within .desktop.
Dec 21 2018, 4:58 PM · Discover Software Store
bam updated the diff for D17671: reflect dependencies.

move yaml also

Dec 21 2018, 4:46 PM · Discover Software Store
bam updated the diff for D17670: remove extra modules.

keep yaml

Dec 21 2018, 4:28 PM · Discover Software Store
bam added a comment to D17662: remove wrapper script.

@apol Last but not least, you could give me a New Year present accepting this patch :-P

Dec 21 2018, 11:00 AM · Discover Software Store

Dec 19 2018

bam added a comment to D17662: remove wrapper script.

... and using FLATPAK_USER_DIR instead of XDG_DATA_HOME

Dec 19 2018, 4:16 PM · Discover Software Store
bam added a comment to D17662: remove wrapper script.

Also, there is other improvement such as 'exec'

Dec 19 2018, 4:15 PM · Discover Software Store
bam added inline comments to D17662: remove wrapper script.
Dec 19 2018, 4:09 PM · Discover Software Store
bam added a comment to D17662: remove wrapper script.

The clue part here is removing the wrapper.sh file.
Also, I don't think we should make a separate module just for the wrapper.

Dec 19 2018, 4:06 PM · Discover Software Store
bam added a comment to D17662: remove wrapper script.
In D17662#379187, @apol wrote:

Why is this better? please provide a better description.

Dec 19 2018, 2:34 PM · Discover Software Store
bam updated the diff for D17662: remove wrapper script.

addresses binary-factory build

Dec 19 2018, 2:19 PM · Discover Software Store

Dec 18 2018

bam added a dependent revision for D17670: remove extra modules: D17671: reflect dependencies.
Dec 18 2018, 11:47 PM · Discover Software Store
bam added a dependency for D17671: reflect dependencies: D17670: remove extra modules.
Dec 18 2018, 11:47 PM · Discover Software Store
bam added a project to D17671: reflect dependencies: Discover Software Store.
Dec 18 2018, 11:47 PM · Discover Software Store
bam requested review of D17671: reflect dependencies.
Dec 18 2018, 11:46 PM · Discover Software Store
bam added a dependent revision for D17669: use more appropriate git branches: D17670: remove extra modules.
Dec 18 2018, 11:41 PM · Discover Software Store
bam added a dependency for D17670: remove extra modules: D17669: use more appropriate git branches.
Dec 18 2018, 11:41 PM · Discover Software Store
bam added a project to D17670: remove extra modules: Discover Software Store.
Dec 18 2018, 11:41 PM · Discover Software Store
bam requested review of D17670: remove extra modules.
Dec 18 2018, 11:40 PM · Discover Software Store
bam added a dependency for D17669: use more appropriate git branches: D17668: remove unneeded filesystem shares.
Dec 18 2018, 11:40 PM · Discover Software Store
bam added a dependent revision for D17668: remove unneeded filesystem shares: D17669: use more appropriate git branches.
Dec 18 2018, 11:40 PM · Discover Software Store
bam added a project to D17669: use more appropriate git branches: Discover Software Store.
Dec 18 2018, 11:39 PM · Discover Software Store
bam requested review of D17669: use more appropriate git branches.
Dec 18 2018, 11:39 PM · Discover Software Store
bam added a dependency for D17668: remove unneeded filesystem shares: D17667: remove unknown option.
Dec 18 2018, 11:38 PM · Discover Software Store
bam added a dependent revision for D17667: remove unknown option: D17668: remove unneeded filesystem shares.
Dec 18 2018, 11:38 PM · Discover Software Store
bam added a project to D17668: remove unneeded filesystem shares: Discover Software Store.
Dec 18 2018, 11:37 PM · Discover Software Store
bam requested review of D17668: remove unneeded filesystem shares.
Dec 18 2018, 11:37 PM · Discover Software Store
bam added a dependency for D17667: remove unknown option: D17666: disable unneeded module properly.
Dec 18 2018, 11:34 PM · Discover Software Store