mak (Matthias Klumpp)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Jul 29 2015, 9:35 AM (167 w, 6 d)
Availability
Available

Recent Activity

Sep 5 2018

mak added a comment to D15221: appstream: make kio-gdrive an addon component.

[...]
Yeah but appstream requires you to set a specific application's .desktop file that the addon is supposed to extend. So for appstream clients it would become "a dolphin addon", not a generic KIO addon.

Sep 5 2018, 9:01 PM

Sep 3 2018

mak added a comment to D15221: appstream: make kio-gdrive an addon component.

You maybe don't want this to be a generic component, but instead make it an addon component instead. See https://www.freedesktop.org/software/appstream/docs/sect-Quickstart-Addons.html
The addon could extend file manages like Dolphin/Konqueror, or even the Plasma Shell itself.

Sep 3 2018, 2:17 AM

Jun 30 2018

mak accepted D13772: Add AppStream metadata.
Jun 30 2018, 3:31 PM · Plasma

Jun 28 2018

mak added a comment to D13772: Add AppStream metadata.

FWIW, @mak, appstrealcli validate doesn't like my launchable tag, though I can't see anything wrong with it.

dev@dev-pc:~/repos/ksysguard$  (appstream-metadata) appstreamcli validate gui/org.kde.ksysguard.appdata.xml
W - org.kde.ksysguard.appdata.xml:org.kde.ksysguard:7
    Found invalid tag: 'launchable'. Non-standard tags must be prefixed with "x-".

Validation failed: warnings: 1
Jun 28 2018, 11:08 PM · Plasma
mak requested changes to D13772: Add AppStream metadata.
Jun 28 2018, 1:24 AM · Plasma

May 27 2018

mak added a comment to D13123: Make .deb and .rpm mime type handling optional at build time.

Checking for the dpkg and rpm binaries isn't really foolproof, because you can install rpm on Debian and dpkg on Fedora & Co. easily.
The only issue proof thing that I can imagine would be checking for the distribution name in /etc/os-release, or maybe checking for the presence of /etc/debian_version.

May 27 2018, 10:28 PM · Plasma

Apr 28 2018

mak added a comment to D12163: Add AppStream release notes for 17.12 to 18.04.

The intent of the "short summary" wording in the AppStream spec for release descriptions is that people don't start to list every single commit that went into the release there, but give a user-friendly translatable overview there instead.
Future releases of AppStream will contain some tooling to add release entries from easier to write formats (Markdown files, YAML, ...), but doing that will not work with KDEs translation process (it would involve translating the XML metainfo file at build-time, while at the moment translations are injected directly into the file by the KDE l10n script - so, to use that KDE would need to use xgettext at build time in combination with e.g. Weblate).

Apr 28 2018, 4:53 PM

Apr 27 2018

mak added a comment to R883:1512080: import new data based on appstream appdata.

@sitter How do you generate this data? All fields from the custom tag should end up in the YAML, if raw libappstream is used. If appstream-generator is used, the custom entries that should end up in the final output need to be whitelisted via the AllowedCustomKeys list field in the asgen configuration file.

Apr 27 2018, 6:09 PM

Apr 10 2018

mak accepted D11124: Add simple appdata file for KDiskFree.
Apr 10 2018, 10:38 AM

Mar 30 2018

mak accepted D11128: Add simple appdata file for Kopete.

LGTM

Mar 30 2018, 9:44 PM · Kopete

Mar 25 2018

mak added a comment to T8237: Appstreamercli tests all fail due on copying some badly named file (appdatafile::desktopfile).

The particular code hasn't been touched in any recent AppStream version, and as far as I can see (at least from the log I found when searching on Jenkins), your AppStream is up to date.
So, I guess it's something else in the image that is broken (especially since this seems to work on other images, I would look for the images generally having no network access, or for some recent curl updates). If appstreamcli is run with the --nonet flag, all actions that require network access are disabled, which can be used as a temporary workaround.

Mar 25 2018, 4:31 AM · build.kde.org

Mar 21 2018

mak added a comment to T8237: Appstreamercli tests all fail due on copying some badly named file (appdatafile::desktopfile).

Which version of AppStream do these SUSE images use? In older versions, AppStream was making only header requests, which some webservers did not allow. So newer versions try to download the first byte of a document instead, which should always work.

Mar 21 2018, 6:11 PM · build.kde.org

Mar 6 2018

mak accepted D11100: Add appdata file for KTimer.
Mar 6 2018, 7:34 PM
mak accepted D11052: Add AppStream metadata.

I also modified the template in the wiki page with the suggested changes. I hope that's fine.
https://community.kde.org/Guidelines_and_HOWTOs/AppStream

Mar 6 2018, 2:18 PM

Mar 5 2018

mak requested changes to D11052: Add AppStream metadata.
Mar 5 2018, 3:02 PM

Mar 4 2018

mak accepted D11030: Add appdata file for KMouseTool.
Mar 4 2018, 9:23 PM
mak accepted D11029: Add appdata file for KMouth.
Mar 4 2018, 9:22 PM
mak accepted D11027: Add appdata file for KGet.
Mar 4 2018, 9:21 PM

Feb 21 2018

mak committed R549:f7e84b2ce9b9: Update AppStream metadata (authored by mak).
Update AppStream metadata
Feb 21 2018, 9:06 PM

Jan 15 2018

mak accepted D9864: Add appstream metadata file.

Looks good to me :-)

Jan 15 2018, 1:11 AM

Oct 9 2017

mak accepted D7986: Add appdata for Filelight.
Oct 9 2017, 6:43 PM

Sep 25 2017

mak added inline comments to D7986: Add appdata for Filelight.
Sep 25 2017, 10:35 PM

Aug 30 2017

mak committed R134:c6d064634f0f: Do not hardcode path to appstream header (authored by mak).
Do not hardcode path to appstream header
Aug 30 2017, 8:28 PM

Aug 28 2017

mak added inline comments to D7567: Support edit and appstream actions also for application search results.
Aug 28 2017, 7:46 PM · Plasma
mak added inline comments to D7567: Support edit and appstream actions also for application search results.
Aug 28 2017, 6:56 PM · Plasma

Aug 17 2017

mak committed R204:23c91fbbc1b7: trivial: Use NoDisplay instead of Hidden for importer .desktop file (authored by mak).
trivial: Use NoDisplay instead of Hidden for importer .desktop file
Aug 17 2017, 3:38 PM

Jul 13 2017

mak added a comment to D6628: Fix and normalize license in .desktop files.

Is there any reason not to use the SPDX license IDs here? => https://spdx.org/licenses/ (e.g. GPL-2.0+ in this case).
In any case, this patch makes things way better, so +1 from me :-)

Jul 13 2017, 1:03 PM · Plasma

Apr 12 2017

mak added a comment to D5405: Create desktop file name based on organization domain unless set explicitely.

I'm still confused. Documentation or not, bad usage or not, is it correct that desktop file name is constructed from both the organization domain AND the homepage?

Apr 12 2017, 4:04 PM · Plasma on Wayland, Frameworks

Mar 20 2017

mak accepted D5052: add appdata file for simon.

Looks good to me! :-)

Mar 20 2017, 12:45 PM · Simon
mak added a comment to D5052: add appdata file for simon.

Hmm, for some weird reason the diff is the same as before...
In order to have the AppStream metadata generator ignore .desktop files that are in /usr/share/applications/ you must add an X-AppStream-Ignore=true field to them (likely to all except for the org.kde.simon.desktop one).
Otherwise, the other .desktop files might show up in software centers as well.

Mar 20 2017, 12:20 PM · Simon

Mar 14 2017

mak added a comment to D5052: add appdata file for simon.

Any app.desktop with Type=Application needs an appdata file?
In this repo that would be simond, afaras, ksimond, sam, scc and sccd

Mar 14 2017, 5:04 PM · Simon

Mar 13 2017

mak accepted D4812: Fix rendering of download progress bar with breeze.

Looks good to me!

Mar 13 2017, 8:46 PM · KDE Applications

Feb 5 2017

mak accepted D4447: Add missing summaries.

Looks good!

Feb 5 2017, 3:36 PM · Plasma

Jan 8 2017

mak committed R549:0f3db8442f5a: Set better icon for Apper (authored by mak).
Set better icon for Apper
Jan 8 2017, 6:55 PM

Jan 6 2017

mak added a comment to D3923: Make AppstreamQt optional.
In D3923#73375, @mak wrote:

In any case, knowing the distro might be useful to check whether their packaging makes sense ;-)

KaOS don't have appstream nor appstreamQt nor Discover (it's a fairly normal when first two are missing)

Jan 6 2017, 6:50 PM · Plasma

Jan 4 2017

mak added a comment to D3943: Make sure we only initialize the appstream pool once.

Looks good!
(appstreamPool is a bit verbose for my taste, AppStream interally calls it dpool (DataPooL) asPool or just pool - but that's just me being lazy and having to type too much n C anyways)

Jan 4 2017, 1:41 AM · Plasma

Jan 3 2017

mak added a comment to D3923: Make AppstreamQt optional.

@davidedmundson What do you mean with big dependency chain? libappstream and libappstreamQt depend in total on only libxml2, libyaml, GLib and Qt5Core which pretty much any distro, especially with Plasma on it, should already have anyway.
Didn't you use Neon? Or was it Manjaro/Arch? In any case, knowing the distro might be useful to check whether their packaging makes sense ;-)

Jan 3 2017, 1:36 AM · Plasma

Nov 21 2016

mak added inline comments to D3434: Manage PackageKit database refresh.
Nov 21 2016, 8:07 PM

Nov 14 2016

mak added a comment to T3722: Developer Environment.

FTR, it always worked, it was just not validated properly ;-)

Nov 14 2016, 5:21 PM · Neon

Oct 31 2016

mak committed R134:f2bd85ec4025: trivial: Fix minor AppStream porting quirk (authored by mak).
trivial: Fix minor AppStream porting quirk
Oct 31 2016, 11:10 PM
mak committed R134:330c670793ed: trivial: Fix terminology (authored by mak).
trivial: Fix terminology
Oct 31 2016, 9:04 PM

Sep 20 2016

mak added a comment to T3722: Developer Environment.

Hard thing to do, because we only allow components of type addon to extend anything, so this can not work (changing that assumption would be massive breakage which I don't want to do).

Sep 20 2016, 4:33 PM · Neon

Jul 28 2016

mak added a comment to T2864: appstream data coverage completion.

@sitter Depends on the amount of pain you want to have with this ^^
I would really not merge the Debian data, because:

  • It might use the wrong packages
  • It might be for a much more recent release than what Ubuntu had available
Jul 28 2016, 1:33 PM · Neon

Jul 27 2016

mak added a comment to T2864: appstream data coverage completion.

Ah, and for incomplete data: If you upload a fixed-up package into Neon, asgen should pick it up and generate valid data. reprocessing the Ubuntu data with a newer asgen isn't possible though, since the Ubuntu data is frozen in time.
(of course you could reprocess the full Ubuntu archive, but that's meh...) reprocessing would IMHO only be interesting as soon as asgen can handle fonts properly.

Jul 27 2016, 2:11 PM · Neon
mak added a comment to T2864: appstream data coverage completion.

@sitter Oh, looks like you misunderstood me there ^^
I think it's fine to fetch the appstream.debian.org output for your Snappy-description hacks - for actually shipping the data with Neon, you should really run asgen on your packages.

Jul 27 2016, 2:09 PM · Neon

Jul 25 2016

mak added a comment to D1816: Switch to Hack as default monospace font.

Hack and Source Code Pro are beautiful fonts for programming - from a Debian perspective, there is no reason to not use Hack, we have it in the archive already (I don't know about Source Code Pro though).

Jul 25 2016, 2:20 PM · Plasma

Jul 22 2016

mak added a comment to D2244: Fix overlapping category names.

Works well for me!

Jul 22 2016, 3:50 PM · Discover Software Store

Jun 16 2016

mak added inline comments to D1844: Add Appinfo metadata file.
Jun 16 2016, 6:28 PM · Plasma

Jun 13 2016

mak added inline comments to D1844: Add Appinfo metadata file.
Jun 13 2016, 1:37 PM · Plasma
mak added inline comments to D1844: Add Appinfo metadata file.
Jun 13 2016, 1:21 PM · Plasma
mak added a comment to D1844: Add Appinfo metadata file.
In D1844#34142, @sebas wrote:

Should also have a screenshot?

Jun 13 2016, 1:00 PM · Plasma

Apr 15 2016

mak committed R134:683642fb214b: Account for components having no package as installation candidate (authored by mak).
Account for components having no package as installation candidate
Apr 15 2016, 6:40 PM
mak committed R134:2041064c3597: Account for components having no package as installation candidate (authored by mak).
Account for components having no package as installation candidate
Apr 15 2016, 6:40 PM

Mar 7 2016

mak committed R134:6e92f5638ddd: Make libDiscoverNotifiers private too (authored by mak).
Make libDiscoverNotifiers private too
Mar 7 2016, 10:30 PM
mak committed R134:02656806b3aa: Make libDiscoverNotifiers private too (authored by mak).
Make libDiscoverNotifiers private too
Mar 7 2016, 10:29 PM
mak committed R134:7e099790f360: Make libdiscover a private library (authored by mak).
Make libdiscover a private library
Mar 7 2016, 10:01 PM
mak committed R134:645226f28d66: Make libdiscover a private library (authored by mak).
Make libdiscover a private library
Mar 7 2016, 10:00 PM
mak closed D1081: Make libdiscover a private library by committing R134:645226f28d66: Make libdiscover a private library.
Mar 7 2016, 10:00 PM · Discover Software Store
mak updated D1081: Make libdiscover a private library.
Mar 7 2016, 6:26 PM · Discover Software Store
mak retitled D1081: Make libdiscover a private library from to Make libdiscover a private library.
Mar 7 2016, 6:23 PM · Discover Software Store

Feb 17 2016

mak committed R73:fe7ec09c52c9: trivial: Use cmake var to install AppStream metainfo (authored by mak).
trivial: Use cmake var to install AppStream metainfo
Feb 17 2016, 1:21 AM

Jan 12 2016

mak added a comment to D797: Require user to authenticate when trying to change lock screen settings.

This breaks every user's backup script by having root files in the user's home. So I am very much not happy with this idea at all.
Especially as it acheives very little anyway, if you have a malicious app on your system - why on Earth does it want to modify your lock screen settings when it has access to everything the user has already?

We want to sandbox apps that might misbehave from the user, not elevate user processes above the user.

Jan 12 2016, 6:34 PM
mak committed R134:36a53af9d3ed: trivial: Small .desktop file style fixes (authored by mak).
trivial: Small .desktop file style fixes
Jan 12 2016, 12:18 AM

Nov 11 2015

mak added a comment to T701: Validate AppStream metadata in the CI.

Okay, I made the latest release available in the vivid suite of that PPA. Adding the PPA will also upgrade glib2 and cmake in the process, I hope that doesn't cause any problems (it actually shouldn't). At least the dependency on a recent GLib2 is necessary.
For Wily, no additional dependencies had to be added, and Xenial already has the latest release in the official repos.

Nov 11 2015, 9:15 PM · build.kde.org
mak added a comment to T701: Validate AppStream metadata in the CI.

The PPA in question already exists, and I use it for Limba, PackageKit and AppStream: https://launchpad.net/~ximion/+archive/ubuntu/packagekit/+packages
The Vivid suite currently holds an up2date AppStream and PackageKit, so other packages that could interfere with something.
I could also create a PPA containing *only* the AppStream package, if you want - but IMHO the ASLIPK repo should be fine :-)

Nov 11 2015, 3:50 PM · build.kde.org
mak added a comment to T701: Validate AppStream metadata in the CI.

I think it would make sense to have a very recent version of appstreamcli, so in case some new checks are added we can benefit from them immediately.
That said, Debian has the latest version in Testing and Unstable, the version in Wily is a little bit outdated and the version in Vivid is very outdated.

Nov 11 2015, 2:09 AM · build.kde.org

Sep 8 2015

mak added a comment to T701: Validate AppStream metadata in the CI.

I just made a release of AppStream which contains the new validate-tree subcommand (still marked as unstable though, means I might change the name of the command or its semantics, although that's not very likely to happen).
Users of Debian unstable just need to upgrade to get it (and have the appstream package installed). I am thinking about filling a sync request for Ubuntu, since their version in the archive is broken with current DEP-11 metadata.

Sep 8 2015, 6:50 PM · build.kde.org

Sep 7 2015

mak lowered the priority of T701: Validate AppStream metadata in the CI from Normal to Wishlist.
Sep 7 2015, 11:59 PM · build.kde.org
mak added a comment to T701: Validate AppStream metadata in the CI.

Oh, I forgot to add: You can get an up-to-date Git snapshot of AppStream via

git clone https://github.com/ximion/appstream.git
mkdir build && cd build
cmake -DCMAKE_INSTALL_PREFIX=/usr ..
make && sudo make install

The dependencies are pretty light, and should be available on any Linux distribution.

Sep 7 2015, 11:58 PM · build.kde.org
mak created T701: Validate AppStream metadata in the CI.
Sep 7 2015, 11:55 PM · build.kde.org