- Queries
- All Stories
- Search
- Advanced Search
Advanced Search
Oct 29 2019
Oct 16 2019
In D24276#548330, @mart wrote:this only affects the old standalone executable, right?
Oct 10 2019
- Add speech synthesis engine selection combobox to general klipper settings page.
Oct 7 2019
Yep, Abandoning.
In D24102#541529, @whiting wrote:In D24102#539859, @sander wrote:Sorry for being a pain, but your patch contains lots of whitespace changes again (in conf/dlgaccessibilitybase.ui). I agree that you probably do want them changed, but please do so in a separate patch.
Besides, can you please post your patch as a merge request on https://invent.kde.org/kde/okular/ ? That is not purely cosmetic -- invent.kde.org has a CI system.
Besides that: I like the patch!
Ok, I'll fix the whitespace and move it to the other review tool, no problem.
Oct 3 2019
In D24102#539859, @sander wrote:Sorry for being a pain, but your patch contains lots of whitespace changes again (in conf/dlgaccessibilitybase.ui). I agree that you probably do want them changed, but please do so in a separate patch.
Besides, can you please post your patch as a merge request on https://invent.kde.org/kde/okular/ ? That is not purely cosmetic -- invent.kde.org has a CI system.
Besides that: I like the patch!
Does anyone have any opinion on this change?
Sep 28 2019
- Add speech synthesis engine selection combobox to general klipper settings page.
- Fix building okular without QTextToSpeech by adding ifdefs.
Sep 26 2019
In D24102#537832, @aacid wrote:Sounds sensible, what about the TODO you have on the top?
- When tts engine is changed via okular settings recreate tts object.
- Only enable Pause or Resume when speaking or paused.
Sep 25 2019
Changed engines stringlist to const and use for instead of foreach.
Thanks for taking this on Tomaz, Just throwing some ideas out but if it would help to have less tabs it might be useful to put all the keyboard features on one tab called Keyboard instead of the 3 it has now (Modifier Keys, Keyboard Filters and Activation Gestures) The top groupbox of Activation Gestures items could be moved to their respective groupboxes also so there are less groupboxes on the Keyboard tab than before on these 3 tabs.
- Add user okular user setting for which QtSpeech engine to use.
Sep 20 2019
Removed whitespace changes.