I should close this task.
- Queries
- All Stories
- Search
- Advanced Search
Feed Advanced Search
Advanced Search
Advanced Search
Jul 12 2019
Jul 12 2019
ah, yes I did. It looks like dbus-daemon is used for a lot of plugin interfaces within KDE Connect.
brute4s99 retitled D21660: remove dbus for windows build and change audio dep logic from remove dbus and change audio dep logic to remove dbus for windows build and change audio dep logic.
no more dbus on Windows build of KNotifications
brute4s99 added inline comments to D21660: remove dbus for windows build and change audio dep logic.
Jul 11 2019
Jul 11 2019
brute4s99 added inline comments to D21660: remove dbus for windows build and change audio dep logic.
Jul 10 2019
Jul 10 2019
Jul 9 2019
Jul 9 2019
add quit option
brute4s99 added inline comments to D21660: remove dbus for windows build and change audio dep logic.
updated
brute4s99 added inline comments to D21660: remove dbus for windows build and change audio dep logic.
rebased
may I land this?
Updated with QT_ pre-procs for S_IFDIR, S_IFLNK and others.
Jul 5 2019
Jul 5 2019
In D21660#481421, @bcooksley wrote:Where possible D-Bus should be avoided on Windows.
brute4s99 committed R877:5e2e59f14194: add snoretoast for win32 builds to knotifs blueprint (authored by brute4s99).
add snoretoast for win32 builds to knotifs blueprint
added handling for WIndows. I'll try it on linux and revert on this patch!
Jul 3 2019
Jul 3 2019
should I land this?
I believe I have covered all the issues with the patch now. (:
renamed variables (start with m_ now)
rename vars
In D22105#489954, @vonreth wrote:Any reason why you skip the symlinks?
I mean displaying thm should be fine, dolphin probably can also follow them.
Creating them on windows is a bit more problematic.
Add NSIS Script for KDE Connect
okay. Landing it. \o/
We still haven't landed KNotifications patch, so I'm waiting on that, since this patch uses SnoreToast call.
We could land it anyway, and instructions related to SnoreToast will just start working after landing the KNotifications patch(es)
Jul 2 2019
Jul 2 2019
Jun 27 2019
Jun 27 2019
add .vscode
Jun 26 2019
Jun 26 2019
brute4s99 committed R877:87759c00f276: add syntax-highlighting dep for building kio-extras (authored by brute4s99).
add syntax-highlighting dep for building kio-extras
Jun 21 2019
Jun 21 2019
brute4s99 committed R877:5cf5882fc8fd: Merge branch 'master' into brute4s99/swish (authored by brute4s99).
Merge branch 'master' into brute4s99/swish
shift swish and comet to libs
brute4s99 committed R877:bf932bfcb71c: Merge branch 'master' into brute4s99/swish (authored by brute4s99).
Merge branch 'master' into brute4s99/swish
same with washer
brute4s99 committed R877:81b62d52c2d4: shift wtl to libs and update swish accoringly (authored by brute4s99).
shift wtl to libs and update swish accoringly
remove boost-signals
brute4s99 committed R877:1f18b7099f5d: remove boost-build(??) and add Washer as dep to swish (authored by brute4s99).
remove boost-build(??) and add Washer as dep to swish
Jun 20 2019
Jun 20 2019
add comet
fix name
brute4s99 committed R877:0ed6c8b9bfcf: Revert "add comet and remove deprecated key from kdeconenct-kde" (authored by brute4s99).
Revert "add comet and remove deprecated key from kdeconenct-kde"
Jun 19 2019
Jun 19 2019
brute4s99 committed R877:4bc4c7859cb1: add comet and remove deprecated key from kdeconenct-kde (authored by brute4s99).
add comet and remove deprecated key from kdeconenct-kde
removed executable key since it's deprecated ✂
brute4s99 committed R834:4240c64dc51e: fix header files destination for SnoreToast (authored by brute4s99).
fix header files destination for SnoreToast
add .arcconfig to SnoreToast
brute4s99 committed R289:2c9578585544: more suggestion fixes and fix broken patch (authored by brute4s99).
more suggestion fixes and fix broken patch
Jun 18 2019
Jun 18 2019
rebased
closing this as duplicate
brute4s99 added inline comments to D21660: remove dbus for windows build and change audio dep logic.
rebased
brute4s99 committed R877:ecdf72305258: remove phonon from deps if building for win32 (authored by brute4s99).
remove phonon from deps if building for win32
awesome! landing this! 🎉
umm, phonon isn't used for Windows notifications with/without the upcoming notifybysnoretoast back-end. Can we not land this?
brute4s99 committed R877:531b4103a225: boost-locale works with lots of hardcoding now (authored by brute4s99).
boost-locale works with lots of hardcoding now
Jun 17 2019
Jun 17 2019
add boost blueprints
Jun 14 2019
Jun 14 2019
updated acc to workaround for MSVC2019 suggested by Hannah
added inline comment for it at L92 -- notifybysnore.cpp
workaround for msvc19
rebased on upstream/master
fix duplicate-ness
Jun 13 2019
Jun 13 2019
fixed crash and added icon removal
updated at 100 comments
updated code incoming. I think I should make a new diff for further discussions, as this one is quite riddled with suggestions now. Are there any more issues with this patch or should I continue with a new one instead? I'm willing to fix it further if you have some suggestions! ✊
Jun 11 2019
Jun 11 2019
brute4s99 committed R289:fabca7f88502: updated acc to new reviews by Hannah and Pino (authored by brute4s99).
updated acc to new reviews by Hannah and Pino
Oh! Apologies, Pino. Actually I accidentally referred to you as toscanos from IRC, so I deleted that comment. I'll avoid deleting them from now on.
updated acc to new reviews by Pino and Hannah
Jun 10 2019
Jun 10 2019
brute4s99 retitled D21660: remove dbus for windows build and change audio dep logic from simplify conditions and remove audio dependency for win32 to change audio dep logic wrt win32.
fixed indentation